You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/07/23 07:11:02 UTC
[GitHub] amrbekhit commented on issue #1286: Add support for the Bosch
BME680 Environmental Sensor
amrbekhit commented on issue #1286: Add support for the Bosch BME680 Environmental Sensor
URL: https://github.com/apache/mynewt-core/pull/1286#issuecomment-406961696
@sterlinghughes Thanks for the review - I'm going through and making the changes. When writing this, I didn't touch the third party code except when necessary, but applied the coding styles to my own additions. Should the third party code be modified to confirm to the coding standards (e.g. regarding things like having function return types be on a separate line)? Some third party files (such as stm32_driver_mod_i2c_v2.c) don't seem to do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services