[GitHub] [ignite-3] lowka commented on a diff in pull request #2468: IGNITE-19951 Enable checks of using NotNull annotation.

["lowka (via GitHub)" <gi...@apache.org>]

lowka commented on code in PR #2468:
URL: https://github.com/apache/ignite-3/pull/2468#discussion_r1302527633


##########
modules/raft/src/test/java/org/apache/ignite/raft/jraft/entity/codec/BaseLogEntryCodecFactoryTest.java:
##########
@@ -68,13 +69,11 @@ public void testEmptyData() {
 
     @Test
     public void testEncodeDecodeEmpty() {
-        try {
+        assertThrows(NullPointerException.class, () -> {

Review Comment:
   Both `assertNull` `fail` are no longer need since `assertThrows` excepts an exception to be thrown.
   
   > assertThrows(NullPointerException.class, () -> { this.encoder.encode(null); });



##########
modules/raft/src/test/java/org/apache/ignite/raft/jraft/entity/codec/BaseLogEntryCodecFactoryTest.java:
##########
@@ -68,13 +69,11 @@ public void testEmptyData() {
 
     @Test
     public void testEncodeDecodeEmpty() {
-        try {
+        assertThrows(NullPointerException.class, () -> {

Review Comment:
   Both `assertNull` `fail` are no longer needed since `assertThrows` excepts an exception to be thrown.
   
   > assertThrows(NullPointerException.class, () -> { this.encoder.encode(null); });



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org