You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ma...@apache.org on 2014/10/02 00:44:43 UTC
git commit: [SPARK-3708][SQL] Backticks aren't handled correctly is
aliases
Repository: spark
Updated Branches:
refs/heads/master d61f2c15b -> 3508ce8a5
[SPARK-3708][SQL] Backticks aren't handled correctly is aliases
The below query gives error
sql("SELECT k FROM (SELECT \`key\` AS \`k\` FROM src) a")
It gives error because the aliases are not cleaned so it could not be resolved in further processing.
Author: ravipesala <ra...@huawei.com>
Closes #2594 from ravipesala/SPARK-3708 and squashes the following commits:
d55db54 [ravipesala] Fixed SPARK-3708 (Backticks aren't handled correctly is aliases)
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/3508ce8a
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/3508ce8a
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/3508ce8a
Branch: refs/heads/master
Commit: 3508ce8a5a05d6cb122ad59ba33c3cc18e17e2a4
Parents: d61f2c1
Author: ravipesala <ra...@huawei.com>
Authored: Wed Oct 1 15:44:41 2014 -0700
Committer: Michael Armbrust <mi...@databricks.com>
Committed: Wed Oct 1 15:44:41 2014 -0700
----------------------------------------------------------------------
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala | 2 +-
.../org/apache/spark/sql/hive/execution/SQLQuerySuite.scala | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/3508ce8a/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala b/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala
index 0aa6292..4f3f808 100644
--- a/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala
+++ b/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala
@@ -855,7 +855,7 @@ private[hive] object HiveQl {
case Token("TOK_SELEXPR",
e :: Token(alias, Nil) :: Nil) =>
- Some(Alias(nodeToExpr(e), alias)())
+ Some(Alias(nodeToExpr(e), cleanIdentifier(alias))())
/* Hints are ignored */
case Token("TOK_HINTLIST", _) => None
http://git-wip-us.apache.org/repos/asf/spark/blob/3508ce8a/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
index 679efe0..3647bb1 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
@@ -63,4 +63,10 @@ class SQLQuerySuite extends QueryTest {
sql("SELECT key, value FROM test_ctas_123 ORDER BY key"),
sql("SELECT key, value FROM src ORDER BY key").collect().toSeq)
}
+
+ test("SPARK-3708 Backticks aren't handled correctly is aliases") {
+ checkAnswer(
+ sql("SELECT k FROM (SELECT `key` AS `k` FROM src) a"),
+ sql("SELECT `key` FROM src").collect().toSeq)
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org