You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by "mitdesai (via GitHub)" <gi...@apache.org> on 2023/05/23 17:34:26 UTC

[GitHub] [yunikorn-k8shim] mitdesai commented on a diff in pull request #597: [YUNIKORN-1650] Add toggle for adding default queue in admission controller

mitdesai commented on code in PR #597:
URL: https://github.com/apache/yunikorn-k8shim/pull/597#discussion_r1202762072


##########
pkg/admission/conf/am_conf.go:
##########
@@ -60,6 +61,9 @@ const (
 	AMAccessControlSystemUsers      = AccessControlPrefix + "systemUsers"
 	AMAccessControlExternalUsers    = AccessControlPrefix + "externalUsers"
 	AMAccessControlExternalGroups   = AccessControlPrefix + "externalGroups"
+
+	// label configurations
+	AMLabelDefaultQueue = LabelPrefix + "defaultQueue"

Review Comment:
   Thanks for the review @craigcondit.
   I think that looks better. Let me update the PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org