[GitHub] [hudi] danny0405 commented on a diff in pull request #6100: [HUDI-4392]Flink MOR table compaction plan execution sequence should …

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #6100:
URL: https://github.com/apache/hudi/pull/6100#discussion_r920714581


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -502,6 +503,14 @@ private FlinkOptions() {
       .defaultValue(true) // default true for MOR write
       .withDescription("Schedule the compaction plan, enabled by default for MOR");
 
+  public static final ConfigOption<String> COMPACTION_SCHEDULE_SEQ = ConfigOptions
+      .key("compaction.schedule.seq")
+      .stringType()
+      .defaultValue(FlinkCompactionConfig.SEQ_LIFO) // default LIFO  to improve compact stability
+      .withDescription("Compaction plan execution sequence, two options are supported:\n"
+      + "1). FIFO: execute the oldest plan first;\n"
+      + "2). LIFO: execute the latest plan first, by default LIFO");

Review Comment:
   Is this necessary ? We only check the `REQUESTED` instant file and if the offline compaction job sees an `INFLIGHT` compaction, it should skip the compaction then, and vice versa.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org