[jira] [Resolved] (HBASE-25676) Move generic classes from hbase-server to hbase-common

["Michael Stack (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-25676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Stack resolved HBASE-25676.
-----------------------------------
    Resolution: Won't Fix

Resolving as "won't fix"

Let me just close this. Most of the classes moved here are used by hbase-server only. Even though a bunch of theses classes are generic and could be used elsewhere other than by hbase-server AND even though a good portion of the content of hbase-common is currently only used by hbase-server, lets favor coherent, contained modules. Closing as wrong direction.

Thanks for reviews [~zhangduo] and @dupg

> Move generic classes from hbase-server to hbase-common
> ------------------------------------------------------
>
>                 Key: HBASE-25676
>                 URL: https://issues.apache.org/jira/browse/HBASE-25676
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Michael Stack
>            Priority: Major
>
> There's a bunch of classes that are not hbase-server specific on cursory review that could live in hbase-common... not many, about 3% of src/main/java but move them out.
> {code}
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/SslRMIClientSocketFactorySecure.java (99%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/SslRMIServerSocketFactorySecure.java (99%)
>   rename {hbase-server/src/main/java/org/apache/hadoop/hbase => hbase-common/src/main/java/org/apache/hadoop/hbase/healthcheck}/HealthCheckChore.java (93%)
>   rename {hbase-server/src/main/java/org/apache/hadoop/hbase => hbase-common/src/main/java/org/apache/hadoop/hbase/healthcheck}/HealthChecker.java (86%)
>   rename {hbase-server/src/main/java/org/apache/hadoop/hbase => hbase-common/src/main/java/org/apache/hadoop/hbase/healthcheck}/HealthReport.java (94%)
>   rename {hbase-server/src/test/java/org/apache/hadoop/hbase => hbase-common/src/test/java/org/apache/hadoop/hbase/healthcheck}/TestNodeHealthCheckChore.java (86%)
>   delete mode 100644 hbase-server/src/main/java/org/apache/hadoop/hbase/DaemonThreadFactory.java
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/security/SecurityUtil.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/ConfigurationUtil.java (99%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/GetJavaProperty.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/HBaseConfTool.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/HashedBytes.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/IdReadWriteLock.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/JvmVersion.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/KeyRange.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/LossyCounting.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/ManualEnvironmentEdge.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/MunkresAssignment.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/NettyEventLoopGroupConfig.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/RollingStatCalculator.java (99%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/ShutdownHookManager.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/SortedList.java (100%)
>   rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/StealJobQueue.java (100%)
>   rename {hbase-server => hbase-common}/src/test/java/org/apache/hadoop/hbase/util/TestConfigurationUtil.java (100%)
>   rename {hbase-server => hbase-common}/src/test/java/org/apache/hadoop/hbase/util/TestIdReadWriteLock.java (100%)
>   rename {hbase-server => hbase-common}/src/test/java/org/apache/hadoop/hbase/util/TestLossyCounting.java (100%)
>   rename {hbase-server => hbase-common}/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java (95%)
>   rename {hbase-server => hbase-common}/src/test/java/org/apache/hadoop/hbase/util/TestSortedList.java (100%)
>   rename {hbase-server => hbase-common}/src/test/java/org/apache/hadoop/hbase/util/TestStealJobQueue.java (100%)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)