You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/07/12 03:25:46 UTC

[GitHub] [echarts] jiawulin001 commented on issue #17350: [Bug] Series symbol rotation is not respected in legends

jiawulin001 commented on issue #17350:
URL: https://github.com/apache/echarts/issues/17350#issuecomment-1181271755

   ## Conclusion
   Adding a method `getLegendIcon()` to scatterSeriesModel can solve this problem. Submitting a PR to solve this.
   
   ## Problem location
   <details>
   <summary>More info</summary>
   
   Interesting enough, I've found that line series would not have such problem becasue of a judgement here:
   https://github.com/apache/echarts/blob/add11459ee43a56f7ff5b300c76b3f801f59f3c6/src/component/legend/LegendView.ts#L371
   Since the method `getLegendIcon()` exists only in `LineSeriesModel` and `MapSeries`, the judgement is not satisfied for scatter chart so the icons styles are not inheritated.
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org