You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by justin-mcdavid-ibm <gi...@git.apache.org> on 2017/03/25 23:03:38 UTC
[GitHub] couchdb-fauxton pull request #884: Variable Cleanup in Styles
GitHub user justin-mcdavid-ibm opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/884
Variable Cleanup in Styles
I'm not entirely done with this effort, but I believe it's in a state where it can be merged in without breaking anything... Everything is compiling for me with no problems, and visual testing hasn't turned up anything terrible.
This effort is mainly around establishing consistent variables (but with varying values) between the two projects dashboard/fauxton, consistently using variables where appropriate, cleaning up unused variables, consistently styling buttons in a L1/L2/L3 scheme, and general changes for interaction consistency. There are still some nails to hammer down on this, but I think it's currently in a state of mergability.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justin-mcdavid-ibm/couchdb-fauxton colorclysm-couch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/884.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #884
----
commit 39fa2af89c82bbf34d3837183b3291160f2dfaaf
Author: Justin McDavid <jm...@us.ibm.com>
Date: 2017-03-25T03:18:04Z
WIP - Reorganizing CSS and Button Stylings
commit f6d12bc144afbc68f4fe44d921898bcdcd658fb5
Author: Justin McDavid <jm...@us.ibm.com>
Date: 2017-03-25T22:49:25Z
Still WIP. More reorg of colors.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #884: Variable Cleanup in Styles
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/884
This is merged in via #886
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #884: Variable Cleanup in Styles
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/884
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #884: Variable Cleanup in Styles
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/884#discussion_r108149915
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -270,7 +270,7 @@ class ChangeRow extends React.Component {
render () {
const { codeVisible } = this.state;
const { change, databaseName } = this.props;
- const jsonBtnClasses = 'btn btn-small' + (codeVisible ? ' btn-secondary' : ' btn-info');
+ const jsonBtnClasses = 'btn btn-small' + (codeVisible ? ' btn-secondary' : ' btn-secondary');
--- End diff --
We can simplify this now:
`const jsonBtnClasses = 'btn btn-small btn-seconday'`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---