You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2024/04/21 10:02:03 UTC
[PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Mryange opened a new pull request, #33934:
URL: https://github.com/apache/doris/pull/33934
## Proposed changes
Correct SQL
```
mysql [tpch_sf100]>select count(1) from lineitem, tmp where l_orderkey > (tmp.id + tmp.id);
+-----------+
| count(1) |
+-----------+
| 600037884 |
+-----------+
```
Incorrect SQL
```
mysql [tpch_sf100]>select count(1) from lineitem, (select id + id as x from tmp) t where l_orderkey > x;
+-----------+
| count(1) |
+-----------+
| 512150170 |
+-----------+
```
The reason for the error is that we have planned the RF, and we have logic to ignore expr execution. However, in cases where there is only one column, _non_predicate_columns will be empty.
Then, in this code...
```cpp
if (!_is_need_vec_eval && !_is_need_short_eval && !_is_need_expr_eval) {
if (_non_predicate_columns.empty()) {
return Status::InternalError("_non_predicate_columns is empty");
}
RETURN_IF_ERROR(_convert_to_expected_type(_first_read_column_ids));
RETURN_IF_ERROR(_convert_to_expected_type(_non_predicate_columns));
_output_non_pred_columns(block);
_output_index_result_column(nullptr, 0, block);
}
```
The previous condition was "_is_need_vec_eval = true," and _non_predicate_columns was empty.
Later, when _is_need_vec_eval is set to false, it will output an empty block.
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068321368
TeamCity be ut coverage result:
Function Coverage: 35.38% (8916/25204)
Line Coverage: 27.10% (73303/270530)
Region Coverage: 26.23% (37870/144355)
Branch Coverage: 23.04% (19279/83686)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1a510741b87e0cf6f15b2c10b0c8c19f4032d8da_1a510741b87e0cf6f15b2c10b0c8c19f4032d8da/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068306010
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068316042
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #33934:
URL: https://github.com/apache/doris/pull/33934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068287459
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068310092
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2067987496
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068056695
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068361998
addd p1 or p2 case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068068395
<details>
<summary>TPC-DS: <b>Total hot run time: 185268 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f089112d91e07d342bd2248e0f2df2df9fc77aa3, data reload: false
query1 913 371 365 365
query2 7205 2442 2401 2401
query3 6655 203 210 203
query4 25517 21263 21269 21263
query5 4203 401 387 387
query6 266 175 169 169
query7 4590 283 280 280
query8 239 185 190 185
query9 8701 2348 2321 2321
query10 594 247 256 247
query11 14899 14319 14287 14287
query12 153 93 87 87
query13 1623 357 348 348
query14 10403 7831 7305 7305
query15 270 189 187 187
query16 8149 255 248 248
query17 1955 569 559 559
query18 2107 274 264 264
query19 321 144 151 144
query20 87 83 82 82
query21 202 125 128 125
query22 5034 4902 4809 4809
query23 33637 33402 33198 33198
query24 10769 2994 2951 2951
query25 615 374 372 372
query26 1364 153 148 148
query27 2879 307 310 307
query28 7629 1989 1978 1978
query29 883 598 600 598
query30 312 173 173 173
query31 961 723 751 723
query32 92 53 52 52
query33 740 242 236 236
query34 1061 464 481 464
query35 825 687 682 682
query36 1047 936 876 876
query37 141 69 78 69
query38 3396 3180 3209 3180
query39 1570 1516 1510 1510
query40 200 125 123 123
query41 45 46 43 43
query42 106 91 96 91
query43 573 538 569 538
query44 1188 727 724 724
query45 285 255 264 255
query46 1075 720 715 715
query47 1939 1848 1880 1848
query48 371 283 302 283
query49 1058 384 376 376
query50 768 384 379 379
query51 6794 6611 6594 6594
query52 98 88 89 88
query53 345 280 276 276
query54 292 231 219 219
query55 71 69 68 68
query56 236 216 217 216
query57 1223 1165 1124 1124
query58 221 189 197 189
query59 3383 3211 3357 3211
query60 252 225 227 225
query61 90 88 86 86
query62 639 449 447 447
query63 298 274 274 274
query64 5547 4109 4028 4028
query65 3155 3028 3030 3028
query66 1405 339 329 329
query67 15725 14972 14964 14964
query68 6142 526 552 526
query69 539 309 312 309
query70 1223 1160 1200 1160
query71 1437 1267 1260 1260
query72 6533 2644 2425 2425
query73 727 320 317 317
query74 6811 6423 6433 6423
query75 3652 2711 2638 2638
query76 3652 938 923 923
query77 656 256 262 256
query78 11027 10201 10273 10201
query79 3174 526 524 524
query80 1331 422 422 422
query81 518 242 245 242
query82 1306 101 98 98
query83 207 167 177 167
query84 257 93 80 80
query85 1482 263 261 261
query86 448 319 295 295
query87 3434 3287 3238 3238
query88 4243 2313 2318 2313
query89 489 366 367 366
query90 1954 177 179 177
query91 133 100 105 100
query92 56 44 49 44
query93 4151 495 492 492
query94 1176 172 174 172
query95 1102 1100 1089 1089
query96 596 262 255 255
query97 3209 2937 2947 2937
query98 236 223 209 209
query99 1282 870 825 825
Total cold run time: 292572 ms
Total hot run time: 185268 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068321202
<details>
<summary>TPC-H: <b>Total hot run time: 38839 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1a510741b87e0cf6f15b2c10b0c8c19f4032d8da, data reload: false
------ Round 1 ----------------------------------
q1 17615 4432 4273 4273
q2 2004 193 195 193
q3 10437 1200 1182 1182
q4 10201 764 790 764
q5 7514 2711 2642 2642
q6 219 133 130 130
q7 1001 605 590 590
q8 9214 2060 2050 2050
q9 7493 6635 6599 6599
q10 8485 3619 3532 3532
q11 458 237 238 237
q12 383 222 213 213
q13 17743 2930 2923 2923
q14 272 236 239 236
q15 528 482 474 474
q16 520 385 373 373
q17 951 677 702 677
q18 7359 6945 6820 6820
q19 2672 1517 1532 1517
q20 655 327 305 305
q21 3519 2792 2848 2792
q22 369 317 324 317
Total cold run time: 109612 ms
Total hot run time: 38839 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4292 4212 4190 4190
q2 362 276 259 259
q3 3033 2744 2698 2698
q4 1856 1571 1580 1571
q5 5361 5354 5314 5314
q6 205 123 122 122
q7 2258 1827 1863 1827
q8 3208 3355 3345 3345
q9 8565 8578 8507 8507
q10 3916 3755 3640 3640
q11 580 484 496 484
q12 752 592 581 581
q13 16362 2914 2943 2914
q14 299 262 278 262
q15 507 474 464 464
q16 473 411 434 411
q17 1764 1475 1470 1470
q18 7599 7589 7388 7388
q19 1693 1572 1590 1572
q20 1939 1744 1758 1744
q21 5006 4702 4895 4702
q22 558 449 464 449
Total cold run time: 70588 ms
Total hot run time: 53914 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068058151
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068289649
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068316000
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068329963
<details>
<summary>TPC-DS: <b>Total hot run time: 187011 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1a510741b87e0cf6f15b2c10b0c8c19f4032d8da, data reload: false
query1 921 378 379 378
query2 6641 2454 2267 2267
query3 6658 212 214 212
query4 23080 21336 21289 21289
query5 4205 433 436 433
query6 281 193 182 182
query7 4584 291 298 291
query8 264 212 217 212
query9 8708 2377 2364 2364
query10 594 266 267 266
query11 14911 14221 14196 14196
query12 149 98 91 91
query13 1657 379 395 379
query14 10250 8125 8036 8036
query15 280 203 191 191
query16 8418 283 283 283
query17 2049 645 596 596
query18 2126 296 296 296
query19 351 163 171 163
query20 95 90 88 88
query21 205 132 131 131
query22 5053 4948 4897 4897
query23 34164 33405 33488 33405
query24 11127 3077 3020 3020
query25 619 407 423 407
query26 709 172 173 172
query27 2238 338 331 331
query28 5878 2050 2051 2050
query29 896 676 645 645
query30 306 182 183 182
query31 994 778 778 778
query32 105 61 62 61
query33 669 285 274 274
query34 895 521 503 503
query35 883 759 749 749
query36 1083 974 954 954
query37 119 78 74 74
query38 3361 3236 3261 3236
query39 1622 1573 1539 1539
query40 206 132 130 130
query41 52 45 46 45
query42 107 104 100 100
query43 582 512 542 512
query44 1139 740 768 740
query45 329 264 276 264
query46 1078 734 773 734
query47 1948 1871 1906 1871
query48 385 310 296 296
query49 1854 430 414 414
query50 768 392 414 392
query51 6765 6710 6560 6560
query52 103 92 95 92
query53 354 286 293 286
query54 332 251 243 243
query55 76 75 75 75
query56 260 241 234 234
query57 1222 1121 1145 1121
query58 225 212 214 212
query59 3195 3160 3202 3160
query60 264 246 245 245
query61 109 106 105 105
query62 642 441 441 441
query63 309 289 287 287
query64 5131 3963 4094 3963
query65 3163 3041 3044 3041
query66 851 366 391 366
query67 15341 15280 14980 14980
query68 5278 542 557 542
query69 501 310 311 310
query70 1268 1181 1155 1155
query71 1402 1272 1279 1272
query72 6534 2742 2539 2539
query73 707 324 324 324
query74 6790 6375 6339 6339
query75 3436 2624 2600 2600
query76 3024 1010 1007 1007
query77 439 320 285 285
query78 11040 10411 10248 10248
query79 5094 548 538 538
query80 1950 464 462 462
query81 547 253 254 253
query82 1191 102 101 101
query83 279 184 182 182
query84 280 97 87 87
query85 1904 324 319 319
query86 486 299 315 299
query87 3473 3315 3271 3271
query88 4609 2348 2332 2332
query89 479 385 375 375
query90 2001 191 193 191
query91 139 111 110 110
query92 67 49 50 49
query93 5548 516 516 516
query94 1245 192 189 189
query95 406 308 308 308
query96 597 264 262 262
query97 3161 2930 2927 2927
query98 247 224 223 223
query99 1208 893 866 866
Total cold run time: 289268 ms
Total hot run time: 187011 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #33934:
URL: https://github.com/apache/doris/pull/33934#discussion_r1573838232
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1957,13 +1957,12 @@ void SegmentIterator::_replace_version_col(size_t num_rows) {
uint16_t SegmentIterator::_evaluate_vectorization_predicate(uint16_t* sel_rowid_idx,
uint16_t selected_size) {
SCOPED_RAW_TIMER(&_opts.stats->vec_cond_ns);
- if (_is_need_vec_eval) {
- _is_need_vec_eval = false;
- for (const auto& pred : _pre_eval_block_predicate) {
- _is_need_vec_eval |= (!pred->always_true());
- }
- }
- if (!_is_need_vec_eval) {
+ bool all_pred_always_true =
+ std::all_of(_pre_eval_block_predicate.begin(), _pre_eval_block_predicate.end(),
+ [](const auto& pred) { return pred->always_true(); });
+
+ //If all predicates are always_true, then return directly.
+ if (all_pred_always_true) {
Review Comment:
这里为什么不检查_is_need_vec_eval？ 按道理说应该是all_pred_always_true || ！_is_need_vec_eval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068289376
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068308477
<details>
<summary>TPC-H: <b>Total hot run time: 38595 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 33f8becf6ace8b27242185f27b351a7c65216183, data reload: false
------ Round 1 ----------------------------------
q1 17622 4442 4493 4442
q2 1995 177 186 177
q3 10484 1154 1162 1154
q4 10189 699 749 699
q5 7512 2684 2655 2655
q6 214 132 131 131
q7 1009 623 577 577
q8 9231 2057 2024 2024
q9 7374 6611 6529 6529
q10 8456 3523 3561 3523
q11 452 235 228 228
q12 549 222 213 213
q13 17765 2918 2929 2918
q14 281 237 226 226
q15 515 472 478 472
q16 530 391 390 390
q17 957 648 680 648
q18 7320 6953 6663 6663
q19 6524 1533 1526 1526
q20 648 320 310 310
q21 3740 2798 2779 2779
q22 370 312 311 311
Total cold run time: 113737 ms
Total hot run time: 38595 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4376 4280 4233 4233
q2 374 283 266 266
q3 3042 2776 2745 2745
q4 1853 1591 1554 1554
q5 5363 5340 5309 5309
q6 210 121 123 121
q7 2194 1849 1870 1849
q8 3222 3366 3367 3366
q9 8567 8520 8544 8520
q10 3871 3665 3735 3665
q11 595 482 473 473
q12 733 583 597 583
q13 17390 2934 2952 2934
q14 291 276 273 273
q15 522 477 478 477
q16 463 410 417 410
q17 1755 1490 1463 1463
q18 8006 7903 7929 7903
q19 1721 1629 1558 1558
q20 2041 1846 1931 1846
q21 5135 5100 4976 4976
q22 549 500 487 487
Total cold run time: 72273 ms
Total hot run time: 55011 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068303098
TeamCity be ut coverage result:
Function Coverage: 35.38% (8917/25205)
Line Coverage: 27.11% (73331/270528)
Region Coverage: 26.24% (37875/144351)
Branch Coverage: 23.05% (19288/83680)
Coverage Report: http://coverage.selectdb-in.cc/coverage/33f8becf6ace8b27242185f27b351a7c65216183_33f8becf6ace8b27242185f27b351a7c65216183/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2067998367
<details>
<summary>TPC-H: <b>Total hot run time: 38297 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fa4974041beab460a24704f4bc51d4b530ddfe4f, data reload: false
------ Round 1 ----------------------------------
q1 17639 4309 4236 4236
q2 2004 187 193 187
q3 10416 1195 1196 1195
q4 10177 869 772 772
q5 7506 2646 2622 2622
q6 215 132 132 132
q7 983 605 577 577
q8 9212 2028 1999 1999
q9 7555 6576 6504 6504
q10 8520 3538 3477 3477
q11 440 236 224 224
q12 442 218 213 213
q13 17765 2922 2924 2922
q14 276 231 242 231
q15 510 485 472 472
q16 533 371 381 371
q17 957 675 663 663
q18 7284 6771 6639 6639
q19 7495 1541 1526 1526
q20 656 324 312 312
q21 3468 2719 2794 2719
q22 367 304 324 304
Total cold run time: 114420 ms
Total hot run time: 38297 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4386 4245 4217 4217
q2 368 268 271 268
q3 2993 2817 2825 2817
q4 1903 1611 1574 1574
q5 5345 5314 5282 5282
q6 210 125 123 123
q7 2246 1809 1891 1809
q8 3188 3370 3300 3300
q9 8575 8511 8634 8511
q10 4103 3905 4007 3905
q11 590 494 514 494
q12 784 642 622 622
q13 17224 3226 3152 3152
q14 337 278 289 278
q15 529 502 476 476
q16 489 430 452 430
q17 1844 1552 1538 1538
q18 8259 7995 7907 7907
q19 1674 1569 1583 1569
q20 2036 1890 1797 1797
q21 8944 5084 5005 5005
q22 544 485 469 469
Total cold run time: 76571 ms
Total hot run time: 55543 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2067989153
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068064549
<details>
<summary>TPC-H: <b>Total hot run time: 38835 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f089112d91e07d342bd2248e0f2df2df9fc77aa3, data reload: false
------ Round 1 ----------------------------------
q1 17912 4561 4391 4391
q2 2766 197 191 191
q3 10766 1210 1170 1170
q4 11271 780 938 780
q5 7862 2787 2641 2641
q6 222 134 134 134
q7 1024 629 607 607
q8 9317 2104 2095 2095
q9 7625 6666 6559 6559
q10 8525 3534 3574 3534
q11 449 233 237 233
q12 428 215 215 215
q13 17763 2914 3004 2914
q14 271 243 232 232
q15 522 481 494 481
q16 512 398 383 383
q17 970 690 702 690
q18 7393 6843 6787 6787
q19 5163 1526 1494 1494
q20 661 307 298 298
q21 3503 2724 2703 2703
q22 363 303 312 303
Total cold run time: 115288 ms
Total hot run time: 38835 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4345 4253 4256 4253
q2 377 273 281 273
q3 3007 2761 2845 2761
q4 1921 1640 1664 1640
q5 5553 5535 5375 5375
q6 208 119 121 119
q7 2221 1863 1899 1863
q8 3225 3385 3372 3372
q9 8618 8604 8562 8562
q10 3936 3677 3708 3677
q11 580 510 474 474
q12 754 599 582 582
q13 17355 2937 2943 2937
q14 292 267 270 267
q15 523 467 476 467
q16 469 414 410 410
q17 1763 1493 1488 1488
q18 7635 7535 7338 7338
q19 1655 1562 1502 1502
q20 1970 1736 1784 1736
q21 4906 4707 4779 4707
q22 540 476 470 470
Total cold run time: 71853 ms
Total hot run time: 54273 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068334171
<details>
<summary>ClickBench: <b>Total hot run time: 30.21 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1a510741b87e0cf6f15b2c10b0c8c19f4032d8da, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.22 0.05 0.06
query4 1.67 0.10 0.10
query5 0.51 0.50 0.52
query6 1.48 0.72 0.72
query7 0.02 0.01 0.02
query8 0.05 0.05 0.04
query9 0.54 0.48 0.48
query10 0.55 0.56 0.54
query11 0.16 0.12 0.11
query12 0.15 0.13 0.13
query13 0.60 0.59 0.59
query14 0.76 0.76 0.79
query15 0.83 0.80 0.81
query16 0.36 0.36 0.37
query17 0.96 0.92 0.98
query18 0.20 0.25 0.23
query19 1.77 1.72 1.66
query20 0.01 0.01 0.01
query21 15.42 0.65 0.64
query22 4.28 7.51 1.78
query23 18.25 1.40 1.31
query24 1.74 0.20 0.23
query25 0.15 0.08 0.08
query26 0.27 0.16 0.15
query27 0.08 0.08 0.08
query28 13.48 1.00 0.99
query29 12.59 3.25 3.22
query30 0.26 0.06 0.06
query31 2.86 0.38 0.38
query32 3.28 0.46 0.46
query33 2.82 2.84 2.84
query34 17.20 4.45 4.43
query35 4.47 4.48 4.55
query36 0.64 0.46 0.45
query37 0.19 0.16 0.15
query38 0.14 0.14 0.14
query39 0.04 0.03 0.04
query40 0.17 0.14 0.14
query41 0.09 0.05 0.04
query42 0.05 0.04 0.04
query43 0.04 0.04 0.04
Total cold run time: 109.47 s
Total hot run time: 30.21 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068001445
<details>
<summary>TPC-DS: <b>Total hot run time: 184278 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fa4974041beab460a24704f4bc51d4b530ddfe4f, data reload: false
query1 891 380 358 358
query2 6176 2657 2305 2305
query3 6653 202 197 197
query4 22868 21316 21316 21316
query5 4191 411 396 396
query6 258 174 169 169
query7 4589 295 282 282
query8 236 183 180 180
query9 8706 2319 2308 2308
query10 409 249 237 237
query11 14688 14285 14154 14154
query12 129 94 84 84
query13 1641 361 356 356
query14 10038 8054 7507 7507
query15 289 179 189 179
query16 8253 258 252 252
query17 2114 553 536 536
query18 2115 281 289 281
query19 345 147 143 143
query20 89 82 85 82
query21 195 122 122 122
query22 5066 4836 4828 4828
query23 33672 33228 33163 33163
query24 10515 3003 2959 2959
query25 594 399 396 396
query26 705 155 151 151
query27 2256 363 370 363
query28 6045 2064 2081 2064
query29 852 612 608 608
query30 304 172 175 172
query31 988 787 757 757
query32 93 52 51 51
query33 649 254 266 254
query34 878 491 489 489
query35 852 740 699 699
query36 1050 928 933 928
query37 114 76 71 71
query38 3507 3349 3378 3349
query39 1052 997 1051 997
query40 178 128 128 128
query41 47 44 43 43
query42 104 92 102 92
query43 559 519 547 519
query44 1109 751 741 741
query45 276 268 264 264
query46 1132 742 733 733
query47 2014 1941 1941 1941
query48 375 301 302 301
query49 839 429 408 408
query50 778 388 380 380
query51 6945 6745 6754 6745
query52 98 91 88 88
query53 346 274 274 274
query54 298 234 231 231
query55 74 71 74 71
query56 242 227 230 227
query57 1195 1113 1118 1113
query58 207 192 193 192
query59 3238 3097 2951 2951
query60 251 225 223 223
query61 90 87 84 84
query62 598 449 468 449
query63 300 274 276 274
query64 4853 4001 3963 3963
query65 3100 3009 3031 3009
query66 744 324 332 324
query67 15335 14968 14924 14924
query68 6600 533 530 530
query69 551 305 303 303
query70 1241 1103 1101 1101
query71 1478 1264 1261 1261
query72 6494 2637 2542 2542
query73 737 316 313 313
query74 6727 6498 6282 6282
query75 3933 2624 2591 2591
query76 4785 934 958 934
query77 643 265 270 265
query78 10921 10080 10135 10080
query79 8260 517 536 517
query80 1508 451 439 439
query81 532 250 244 244
query82 1124 100 94 94
query83 198 166 166 166
query84 271 85 86 85
query85 1287 375 264 264
query86 447 314 306 306
query87 3440 3272 3266 3266
query88 4906 2337 2348 2337
query89 540 379 371 371
query90 1927 181 181 181
query91 121 94 96 94
query92 60 45 45 45
query93 6589 508 501 501
query94 1000 232 179 179
query95 374 291 299 291
query96 611 265 258 258
query97 3144 2960 2938 2938
query98 229 213 225 213
query99 1239 852 887 852
Total cold run time: 291307 ms
Total hot run time: 184278 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068289635
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #33934:
URL: https://github.com/apache/doris/pull/33934#discussion_r1573731994
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1957,7 +1957,10 @@ void SegmentIterator::_replace_version_col(size_t num_rows) {
uint16_t SegmentIterator::_evaluate_vectorization_predicate(uint16_t* sel_rowid_idx,
uint16_t selected_size) {
SCOPED_RAW_TIMER(&_opts.stats->vec_cond_ns);
- if (_is_need_vec_eval) {
+ // The expr can only be skipped when _non_predicate_columns is not empty;
+ // otherwise, skipping the expr could result in an empty block
+ // being output while _non_predicate_columns is empty.
+ if (_is_need_vec_eval && !_non_predicate_columns.empty()) {
Review Comment:
why the output will be empty block? since we already read the predicate column into current_return_columns and line 1970 will set all flags to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2067993304
TeamCity be ut coverage result:
Function Coverage: 35.38% (8918/25204)
Line Coverage: 27.10% (73306/270519)
Region Coverage: 26.24% (37876/144362)
Branch Coverage: 23.04% (19284/83688)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fa4974041beab460a24704f4bc51d4b530ddfe4f_fa4974041beab460a24704f4bc51d4b530ddfe4f/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068002796
<details>
<summary>ClickBench: <b>Total hot run time: 30.52 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fa4974041beab460a24704f4bc51d4b530ddfe4f, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.03
query3 0.23 0.06 0.06
query4 1.65 0.09 0.09
query5 0.50 0.50 0.52
query6 1.48 0.73 0.71
query7 0.02 0.01 0.02
query8 0.04 0.04 0.04
query9 0.54 0.49 0.50
query10 0.54 0.56 0.56
query11 0.15 0.12 0.12
query12 0.14 0.11 0.12
query13 0.59 0.59 0.58
query14 0.76 0.76 0.78
query15 0.82 0.81 0.81
query16 0.35 0.36 0.36
query17 0.99 0.98 0.94
query18 0.22 0.21 0.27
query19 1.75 1.69 1.71
query20 0.02 0.01 0.01
query21 15.41 0.65 0.64
query22 3.77 8.11 2.06
query23 18.30 1.41 1.30
query24 1.77 0.26 0.19
query25 0.14 0.08 0.08
query26 0.26 0.16 0.16
query27 0.08 0.08 0.08
query28 13.36 1.00 0.99
query29 12.56 3.25 3.27
query30 0.26 0.06 0.06
query31 2.87 0.39 0.38
query32 3.27 0.46 0.46
query33 2.80 2.92 2.82
query34 17.24 4.41 4.40
query35 4.48 4.50 4.47
query36 0.64 0.48 0.49
query37 0.18 0.15 0.16
query38 0.17 0.15 0.15
query39 0.04 0.04 0.03
query40 0.16 0.14 0.13
query41 0.10 0.05 0.05
query42 0.06 0.06 0.05
query43 0.04 0.04 0.03
Total cold run time: 108.87 s
Total hot run time: 30.52 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068063967
TeamCity be ut coverage result:
Function Coverage: 35.37% (8916/25205)
Line Coverage: 27.09% (73283/270517)
Region Coverage: 26.23% (37869/144356)
Branch Coverage: 23.04% (19276/83680)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f089112d91e07d342bd2248e0f2df2df9fc77aa3_f089112d91e07d342bd2248e0f2df2df9fc77aa3/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #33934:
URL: https://github.com/apache/doris/pull/33934#discussion_r1573838133
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1957,13 +1957,12 @@ void SegmentIterator::_replace_version_col(size_t num_rows) {
uint16_t SegmentIterator::_evaluate_vectorization_predicate(uint16_t* sel_rowid_idx,
uint16_t selected_size) {
SCOPED_RAW_TIMER(&_opts.stats->vec_cond_ns);
- if (_is_need_vec_eval) {
- _is_need_vec_eval = false;
- for (const auto& pred : _pre_eval_block_predicate) {
- _is_need_vec_eval |= (!pred->always_true());
- }
- }
- if (!_is_need_vec_eval) {
+ bool all_pred_always_true =
Review Comment:
不要这么写，这么写语义并不是很清楚。
比如_pre_eval_block_predicate 为空的时候，这个值是多少？ 先设置一个变量，然后再赋值。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange closed pull request #33934: [fix](scan) fix ignore expr exec when _non_predicate_columns is empty
URL: https://github.com/apache/doris/pull/33934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068308943
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2067988960
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](scan) fix ignore expr exec when _non_predicate_columns is empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #33934:
URL: https://github.com/apache/doris/pull/33934#issuecomment-2068070260
<details>
<summary>ClickBench: <b>Total hot run time: 30.2 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f089112d91e07d342bd2248e0f2df2df9fc77aa3, data reload: false
query1 0.04 0.04 0.03
query2 0.09 0.04 0.04
query3 0.23 0.04 0.05
query4 1.67 0.06 0.06
query5 0.50 0.50 0.51
query6 1.48 0.72 0.73
query7 0.02 0.01 0.01
query8 0.06 0.04 0.04
query9 0.56 0.50 0.49
query10 0.54 0.55 0.55
query11 0.16 0.11 0.11
query12 0.14 0.12 0.13
query13 0.61 0.58 0.58
query14 0.75 0.79 0.77
query15 0.82 0.80 0.80
query16 0.38 0.37 0.36
query17 1.00 0.93 0.95
query18 0.23 0.22 0.24
query19 1.73 1.71 1.79
query20 0.01 0.01 0.02
query21 15.41 0.63 0.64
query22 4.22 7.67 1.78
query23 18.31 1.40 1.27
query24 1.48 0.43 0.19
query25 0.15 0.08 0.08
query26 0.25 0.16 0.16
query27 0.08 0.09 0.07
query28 13.29 1.00 0.98
query29 12.58 3.26 3.25
query30 0.27 0.07 0.05
query31 2.85 0.38 0.37
query32 3.28 0.46 0.46
query33 2.80 2.85 2.86
query34 17.24 4.42 4.47
query35 4.50 4.60 4.49
query36 0.65 0.46 0.46
query37 0.19 0.15 0.15
query38 0.16 0.15 0.14
query39 0.05 0.03 0.03
query40 0.19 0.15 0.15
query41 0.09 0.05 0.05
query42 0.05 0.04 0.05
query43 0.04 0.04 0.04
Total cold run time: 109.15 s
Total hot run time: 30.2 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org