You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "mawiesne (via GitHub)" <gi...@apache.org> on 2023/07/29 12:25:08 UTC
[GitHub] [commons-collections] mawiesne opened a new pull request, #409: Fix punctuation and minor JavaDoc issues
mawiesne opened a new pull request, #409:
URL: https://github.com/apache/commons-collections/pull/409
- fixes misplaced symbols in JavaDoc (mainly in Hasher, CountingLongPre…
- resolves grammar and punctuation issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] mawiesne commented on pull request #409: Fix punctuation and minor JavaDoc issues
Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne commented on PR #409:
URL: https://github.com/apache/commons-collections/pull/409#issuecomment-1656719159
Ping @garydgregory @kinow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] garydgregory merged pull request #409: Fix punctuation and minor JavaDoc issues
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #409:
URL: https://github.com/apache/commons-collections/pull/409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] codecov-commenter commented on pull request #409: Fix punctuation and minor JavaDoc issues
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #409:
URL: https://github.com/apache/commons-collections/pull/409#issuecomment-1656719298
## [Codecov](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#409](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d82c18e) into [master](https://app.codecov.io/gh/apache/commons-collections/commit/8a0d6b0da50f6dbedec4bdb3c30d4170ff68263d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8a0d6b0) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #409 +/- ##
=========================================
Coverage 81.20% 81.20%
Complexity 4625 4625
=========================================
Files 290 290
Lines 13483 13483
Branches 1993 1993
=========================================
Hits 10949 10949
Misses 1933 1933
Partials 601 601
```
| [Files Changed](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/commons/collections4/MapUtils.java](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L01hcFV0aWxzLmphdmE=) | `93.30% <ø> (ø)` | |
| [...rg/apache/commons/collections4/PredicateUtils.java](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L1ByZWRpY2F0ZVV0aWxzLmphdmE=) | `83.87% <ø> (ø)` | |
| [...org/apache/commons/collections4/SplitMapUtils.java](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L1NwbGl0TWFwVXRpbHMuamF2YQ==) | `73.58% <ø> (ø)` | |
| [.../apache/commons/collections4/TransformerUtils.java](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L1RyYW5zZm9ybWVyVXRpbHMuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ections4/bloomfilter/ArrayCountingBloomFilter.java](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2Jsb29tZmlsdGVyL0FycmF5Q291bnRpbmdCbG9vbUZpbHRlci5qYXZh) | `100.00% <ø> (ø)` | |
| [...ollections4/bloomfilter/CountingLongPredicate.java](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2Jsb29tZmlsdGVyL0NvdW50aW5nTG9uZ1ByZWRpY2F0ZS5qYXZh) | `100.00% <ø> (ø)` | |
| [...collections4/bloomfilter/EnhancedDoubleHasher.java](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2Jsb29tZmlsdGVyL0VuaGFuY2VkRG91YmxlSGFzaGVyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...pache/commons/collections4/bloomfilter/Hasher.java](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2Jsb29tZmlsdGVyL0hhc2hlci5qYXZh) | `100.00% <ø> (ø)` | |
| [.../collections4/collection/PredicatedCollection.java](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2NvbGxlY3Rpb24vUHJlZGljYXRlZENvbGxlY3Rpb24uamF2YQ==) | `88.13% <ø> (ø)` | |
| [...he/commons/collections4/functors/WhileClosure.java](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2Z1bmN0b3JzL1doaWxlQ2xvc3VyZS5qYXZh) | `80.00% <ø> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/commons-collections/pull/409?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] mawiesne commented on pull request #409: Fix punctuation and minor JavaDoc issues
Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne commented on PR #409:
URL: https://github.com/apache/commons-collections/pull/409#issuecomment-1656857879
> Would you please update the PR to not touch that package?
I did - changes in bloomfilter package reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org