You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by or...@apache.org on 2013/10/14 18:16:15 UTC

svn commit: r1531965 - in /qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources: ./ js/qpid/common/ js/qpid/common/grid/ js/qpid/management/ js/qpid/management/logs/

Author: orudyy
Date: Mon Oct 14 16:16:15 2013
New Revision: 1531965

URL: http://svn.apache.org/r1531965
Log:
QPID-5138: Add improvements and fixes into Web Management Console preferences:
           Use UTC time zone by default if no time zone is set
           Create preferences dialog on demand
           Enable preferences Set buttons only when changes are made
           Display log viewer last update time for preferred and browser time zones
           Fix provider name editing

Added:
    qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/ConsoleHelper.js
Modified:
    qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/index.html
    qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/TimeZoneSelector.js
    qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/EnhancedFilter.js
    qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/EnhancedFilterTools.js
    qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/GridUpdater.js
    qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/Preferences.js
    qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/PreferencesProviderFields.js
    qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/UserPreferences.js
    qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/logs/LogViewer.js

Modified: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/index.html
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/index.html?rev=1531965&r1=1531964&r2=1531965&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/index.html (original)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/index.html Mon Oct 14 16:16:15 2013
@@ -57,33 +57,24 @@
     </script>
 
     <script>
-        var qpidHelpLocation = "http://qpid.apache.org/releases/qpid-";
-        var qpidHelpURL = null;
-        var qpidPreferences = null;
+        var qpidManagementHelper = null;
         require([
-                    "dojo/_base/xhr",
                     "dojo/parser",
-                    "qpid/management/Preferences",
                     "qpid/authorization/checkUser",
+                    "qpid/common/ConsoleHelper",
                     "dijit/layout/BorderContainer",
                     "dijit/layout/TabContainer",
                     "dijit/layout/ContentPane",
                     "dijit/TitlePane",
+                    "dijit/Menu",
+                    "dijit/MenuItem",
                     "qpid/management/treeView",
                     "qpid/management/controller",
                     "qpid/common/footer"
-                    ], function(xhr, parser, Preferences, User){
+                    ], function(parser, User, ConsoleHelper){
                         parser.parse();
+                        qpidManagementHelper = ConsoleHelper;
                         User.getUserAndUpdateUI();
-                        qpidPreferences = new Preferences();
-                         xhr.get({
-                                sync: true,
-                                url: "rest/helper?action=version",
-                                handleAs: "json"
-                         }).then(function(qpidVersion) {
-                            qpidHelpURL = qpidHelpLocation + qpidVersion + "/java-broker/book/index.html";
-                         });
-
                     });
     </script>
 
@@ -98,20 +89,10 @@
             <div id="authenticatedUserControls" data-dojo-type="dijit.form.DropDownButton" data-dojo-props="iconClass: 'preferencesIcon', style:{'max-width': '100px'}">
             <div data-dojo-type="dijit.Menu">
                 <div data-dojo-type="dijit.MenuItem" data-dojo-props="onClick: function(){window.location='logout';}" >Log out</div>
-                <div data-dojo-type="dijit.MenuItem" data-dojo-props="
-                        iconClass: 'dijitIconFunction',
-                        onClick: function(){ qpidPreferences.showDialog(); } ">
-                    Preferences
-                </div>
-                <!--
-                <div data-dojo-type="dijit.MenuItem" data-dojo-props="iconClass: 'dijitIconMail', onClick: function(){ console.log('TODO'); }">
-                    Contacts
-                </div>
-                 -->
-                <div data-dojo-type="dijit.MenuItem" data-dojo-props="iconClass: 'helpIcon', onClick: function(){
-                     var newWindow = window.open(qpidHelpURL,'QpidHelp','height=600,width=600,scrollbars=1,location=1,resizable=1,status=0,toolbar=0,titlebar=1,menubar=0',true); newWindow.focus(); } ">
-                    Help
-                </div>
+                <div data-dojo-type="dijit.MenuItem"
+                    data-dojo-props="iconClass:'dijitIconFunction',onClick: function(){qpidManagementHelper.showPreferencesDialog();}">Preferences</div>
+                <div data-dojo-type="dijit.MenuItem"
+                    data-dojo-props="iconClass: 'helpIcon', onClick: function(){qpidManagementHelper.showHelp();}">Help</div>
             </div>
           </div>
         </div>

Added: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/ConsoleHelper.js
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/ConsoleHelper.js?rev=1531965&view=auto
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/ConsoleHelper.js (added)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/ConsoleHelper.js Mon Oct 14 16:16:15 2013
@@ -0,0 +1,73 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+define(["dojo/_base/xhr", "dojo/domReady!"], function (xhr) {
+
+    var qpidHelpLocation = "http://qpid.apache.org/releases/qpid-";
+    var preferencesDialog = null;
+    var helpURL = null;
+    var qpidVersion = null;
+
+    return {
+        showPreferencesDialog: function () {
+          if (preferencesDialog == null)
+          {
+             require(["qpid/management/Preferences", "dojo/ready"], function(PreferencesDialog, ready){
+                ready(function(){
+                  preferencesDialog = new PreferencesDialog();
+                  preferencesDialog.showDialog();
+                });
+             });
+          }
+          else
+          {
+              preferencesDialog.showDialog();
+          }
+        },
+        getVersion: function()
+        {
+          if (!qpidVersion)
+          {
+            xhr.get({
+              sync: true,
+              url: "rest/helper?action=version",
+              handleAs: "json"
+             }).then(function(version) {
+               qpidVersion = version;
+             });
+          }
+          return qpidVersion;
+        },
+        getHelpUrl: function()
+        {
+          if (!helpURL)
+          {
+            helpURL = qpidHelpLocation + this.getVersion() + "/java-broker/book/index.html";
+          }
+          return helpURL;
+        },
+        showHelp: function()
+        {
+          var newWindow = window.open(this.getHelpUrl(),'QpidHelp','height=600,width=600,scrollbars=1,location=1,resizable=1,status=0,toolbar=0,titlebar=1,menubar=0', true);
+          newWindow.focus();
+        }
+    };
+
+});

Modified: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/TimeZoneSelector.js
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/TimeZoneSelector.js?rev=1531965&r1=1531964&r2=1531965&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/TimeZoneSelector.js (original)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/TimeZoneSelector.js Mon Oct 14 16:16:15 2013
@@ -114,6 +114,7 @@ function (declare, array, domConstruct, 
         }
         self._citySelector.set("disabled", checked);
         self._regionSelector.set("disabled", checked);
+        self._handleOnChange(self.value);
       });
       this._regionSelector.on("change", function(value){
         if (value=="undefined")
@@ -122,6 +123,7 @@ function (declare, array, domConstruct, 
           self._citySelector.query.region = /.*/;
           self.value = null;
           self._citySelector.set("value", null);
+          self._handleOnChange(self.value);
         }
         else
         {
@@ -141,6 +143,7 @@ function (declare, array, domConstruct, 
 
       this._citySelector.on("change", function(value){
         self.value = value;
+        self._handleOnChange(value);
       });
 
       this._setValueAttr(this._args.value);
@@ -176,6 +179,7 @@ function (declare, array, domConstruct, 
         this._regionSelector.set("value", "undefined");
       }
       this.value = value;
+      this._handleOnChange(value);
     },
 
     destroy: function()
@@ -188,6 +192,25 @@ function (declare, array, domConstruct, 
       _regionSelector: null;
       _citySelector: null;
       _utcSelector: null;
+    },
+
+    onChange: function(newValue){},
+
+    _handleOnChange: function(newValue)
+    {
+      if (this._lastValueReported != newValue)
+      {
+        this._lastValueReported = newValue;
+        if(this._onChangeHandle)
+        {
+          this._onChangeHandle.remove();
+        }
+        this._onChangeHandle = this.defer(function()
+        {
+            this._onChangeHandle = null;
+            this.onChange(newValue);
+        });
+      }
     }
 
   });

Modified: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/EnhancedFilter.js
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/EnhancedFilter.js?rev=1531965&r1=1531964&r2=1531965&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/EnhancedFilter.js (original)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/EnhancedFilter.js Mon Oct 14 16:16:15 2013
@@ -96,6 +96,7 @@ define([
       }
       this.defaulGridRowLimit = args.defaulGridRowLimit;
       this.disableFiltering = args.disableFiltering;
+      this.displayLastUpdateTime = args.displayLastUpdateTime;
 
       //Install UI components
       var obj = { "plugin": this };
@@ -147,6 +148,7 @@ define([
           filterDefDialog: this.filterDefDialog,
           defaulGridRowLimit: this.defaulGridRowLimit,
           disableFiltering: this.disableFiltering,
+          displayLastUpdateTime: this.displayLastUpdateTime,
           nls: nls,
           ruleCountToConfirmClearFilter: this.ruleCountToConfirmClearFilter
         });

Modified: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/EnhancedFilterTools.js
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/EnhancedFilterTools.js?rev=1531965&r1=1531964&r2=1531965&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/EnhancedFilterTools.js (original)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/EnhancedFilterTools.js Mon Oct 14 16:16:15 2013
@@ -22,12 +22,15 @@
 define([
   "dojo/_base/declare",
   "dojo/_base/event",
+  "dojo/dom-construct",
+  "dojo/date/locale",
   "dijit/form/Button",
   "dijit/form/ToggleButton",
   "qpid/common/grid/RowNumberLimitDialog",
   "qpid/common/grid/ColumnDefDialog",
-  "qpid/common/grid/FilterSummary"
-], function(declare, event, Button, ToggleButton, RowNumberLimitDialog, ColumnDefDialog, FilterSummary){
+  "qpid/common/grid/FilterSummary",
+  "qpid/management/UserPreferences"
+], function(declare, event, domConstruct, locale, Button, ToggleButton, RowNumberLimitDialog, ColumnDefDialog, FilterSummary, UserPreferences){
 
   var _stopEvent = function (evt){
     try{
@@ -65,6 +68,7 @@ define([
       this.clearFilterDialog = params.clearFilterDialog;
       this.filterDefDialog = params.filterDefDialog;
       this.ruleCountToConfirmClearFilter = params.ruleCountToConfirmClearFilter;
+      this.displayLastUpdateTime = params.hasOwnProperty("displayLastUpdateTime")?params.displayLastUpdateTime:true;
 
       this._addRefreshButtons();
       this._addRowLimitButton(params.defaulGridRowLimit);
@@ -168,6 +172,38 @@ define([
 
       this.filterBar.addChild(this.autoRefreshButton);
       this.filterBar.addChild(this.refreshButton);
+
+      if (this.displayLastUpdateTime)
+      {
+        var updateStatusPanel = domConstruct.create("div");
+        var updateTimeLabel = domConstruct.create("span", {innerHTML: "Update time: ", "class": "formLabel-labelCell", "style": "padding-right: 5px;padding-left: 5px"}, updateStatusPanel);
+        var updateTimeLabelPreferredTZ = domConstruct.create("span", {innerHTML: "Preferred timezone:", "style": "padding-right: 5px"}, updateStatusPanel);
+        var updateTimePreferredTZ = domConstruct.create("span", {"style": "padding-right: 5px"}, updateStatusPanel);
+        var updateTimeLabelBrowserTZ = domConstruct.create("span", {innerHTML: "Browser timezone:", "style": "padding-right: 5px"}, updateStatusPanel);
+        var updateTimeBrowserTZ = domConstruct.create("span", {"style": "padding-right: 5px"}, updateStatusPanel);
+
+        var lastUpdateTimeUpdater = function(data)
+        {
+          var userTimeZone = UserPreferences.timeZone;
+          var displayStyle = userTimeZone? "inline" : "none";
+          updateTimeLabelPreferredTZ.style.display = displayStyle;
+          updateTimePreferredTZ.style.display = displayStyle;
+          var formatOptions = {selector: "time", timePattern: "HH:mm:ss.SSS", appendTimeZone: true, addOffset: true};
+          var updateTime = new Date();
+          updateTimePreferredTZ.innerHTML = UserPreferences.formatDateTime(updateTime.getTime(), formatOptions);
+          updateTimeBrowserTZ.innerHTML = locale.format(updateTime, formatOptions);
+        };
+
+        if (self.grid.updater.store)
+        {
+          // data have been already provided/or fetched
+          // set last update time to current time
+          lastUpdateTimeUpdater();
+        }
+
+        self.grid.updater.addOnUpdate(lastUpdateTimeUpdater);
+        domConstruct.place(updateStatusPanel, this.grid.viewsHeaderNode, "before");
+      }
     },
 
     _addRowLimitButton: function(defaulGridRowLimit)
@@ -241,6 +277,9 @@ define([
 
       this.filterDefButton.on("click", function(e){
         _stopEvent(e);
+
+        // a bit of a hack to force dialog to rebuild the criteria controls in order to get rid from empty rule controls
+        self.filterDefDialog._criteriasChanged = true;
         self.filterDefDialog.showDialog();
       });
 

Modified: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/GridUpdater.js
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/GridUpdater.js?rev=1531965&r1=1531964&r2=1531965&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/GridUpdater.js (original)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/common/grid/GridUpdater.js Mon Oct 14 16:16:15 2013
@@ -39,7 +39,11 @@ define(["dojo/_base/xhr",
              this.updatable = args.hasOwnProperty("updatable") ? args.updatable : true ;
              this.serviceUrl = args.serviceUrl;
 
-             this.onUpdate = args.onUpdate;
+             this.onUpdate = [];
+             if (args.onUpdate)
+             {
+               this.onUpdate.push(args.onUpdate);
+             }
              this.dataTransformer = args.dataTransformer;
 
              this.appendData = args.append;
@@ -146,17 +150,10 @@ define(["dojo/_base/xhr",
 
                  if (data)
                  {
-                     try
-                     {
-                         if ((dataSet || self.updateOrAppend(data)) && self.onUpdate)
-                         {
-                             self.onUpdate(data);
-                         }
-                     }
-                     catch(e)
-                     {
-                         console.error(e);
-                     }
+                   if ((dataSet || self.updateOrAppend(data)) && self.onUpdate.length > 0)
+                   {
+                     self.fireUpdate(data);
+                   }
                  }
              };
 
@@ -191,6 +188,7 @@ define(["dojo/_base/xhr",
              this.store = null;
              this.memoryStore = null;
              this.grid = null;
+             this.onUpdate = null;
            };
 
            GridUpdater.prototype.updateOrAppend = function(data)
@@ -232,10 +230,7 @@ define(["dojo/_base/xhr",
                finally
                {
                    this.updating = false;
-                   if (this.onUpdate)
-                   {
-                     this.onUpdate(data);
-                   }
+                   this.fireUpdate(data);
                }
            }
 
@@ -263,5 +258,40 @@ define(["dojo/_base/xhr",
                }
            };
 
+           GridUpdater.prototype.fireUpdate=function(data)
+           {
+             if (this.onUpdate.length > 0)
+             {
+               for(var i=0; i<this.onUpdate.length;i++)
+               {
+                 var onUpdate= this.onUpdate[i];
+                 try
+                 {
+                   onUpdate(data);
+                 }
+                 catch(e)
+                 {
+                   if (console && console.error)
+                   {
+                     console.error(e);
+                   }
+                 }
+               }
+             }
+           };
+
+           GridUpdater.prototype.addOnUpdate = function(obj) {
+             this.onUpdate.push(obj);
+           };
+
+           GridUpdater.prototype.removeOnUpdate = function(obj) {
+             for(var i = 0; i < this.onUpdate.length; i++) {
+                 if(this.onUpdate[i] === obj) {
+                   this.onUpdate.splice(i,1);
+                   return;
+                 }
+             }
+           };
+
            return GridUpdater;
        });

Modified: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/Preferences.js
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/Preferences.js?rev=1531965&r1=1531964&r2=1531965&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/Preferences.js (original)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/Preferences.js Mon Oct 14 16:16:15 2013
@@ -71,20 +71,21 @@ function (declare, xhr, event, connect, 
       {
         var name = preferenceNames[i];
         this[name] = registry.byId("preferences." + name);
+        this[name].on("change", function(val){that._toggleSetButtons();});
       }
 
       this.setButton = registry.byId("preferences.setButton");
       this.setAndCloseButton = registry.byId("preferences.setAndCloseButton");
-      this.setButton.on("click", function(e){that._savePreferences(e, false)});
-      this.setAndCloseButton.on("click", function(e){that._savePreferences(e, true)});
+      this.setButton.on("click", function(e){that._savePreferences(e, false);});
+      this.setAndCloseButton.on("click", function(e){that._savePreferences(e, true);});
       this.theForm = registry.byId("preferences.preferencesForm");
       this.usersGrid = registry.byId("preferences.users");
       this.usersGrid.set("structure", [ { name: "User", field: "name", width: "50%"},
                                  { name: "Authentication Provider", field: "authenticationProvider", width: "50%"}]);
       this.deleteButton = registry.byId("preferences.deleteButton");
       this.deleteAndCloseButton = registry.byId("preferences.deleteAndCloseButton");
-      this.deleteButton.on("click", function(e){that._deletePreferences(false)});
-      this.deleteAndCloseButton.on("click", function(e){that._deletePreferences(true)});
+      this.deleteButton.on("click", function(e){that._deletePreferences(false);});
+      this.deleteAndCloseButton.on("click", function(e){that._deletePreferences(true);});
 
       var deletePreferencesButtonToggler = function(rowIndex){
         var data = that.usersGrid.selection.getSelected();
@@ -160,8 +161,8 @@ function (declare, xhr, event, connect, 
                 {
                   that._loadUserPreferences();
                 }
-                alert("Preferences stored successfully");
               }
+              that._toggleSetButtons();
             },
             function(error){alert("Error:" + error);}
         );
@@ -220,6 +221,7 @@ function (declare, xhr, event, connect, 
           }
         }
       }
+      this._toggleSetButtons();
     },
 
     _loadUserPreferences : function()
@@ -245,6 +247,27 @@ function (declare, xhr, event, connect, 
              that.usersGrid.set("store", usersDataStore);
              that.usersGrid._refresh();
       });
+    },
+
+    _toggleSetButtons: function()
+    {
+      var changed = false;
+      for(var i=0; i<preferenceNames.length; i++)
+      {
+        var name = preferenceNames[i];
+        var preferenceWidget = this[name];
+        if (preferenceWidget)
+        {
+          var value = preferenceWidget.hasOwnProperty("checked") ? preferenceWidget.checked : preferenceWidget.get("value");
+          if (value != UserPreferences[name])
+          {
+            changed = true;
+            break;
+          }
+        }
+      }
+      this.setButton.set("disabled", !changed);
+      this.setAndCloseButton.set("disabled", !changed);
     }
 
   });

Modified: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/PreferencesProviderFields.js
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/PreferencesProviderFields.js?rev=1531965&r1=1531964&r2=1531965&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/PreferencesProviderFields.js (original)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/PreferencesProviderFields.js Mon Oct 14 16:16:15 2013
@@ -48,6 +48,9 @@ define(["dojo/_base/xhr",
   {
     if(type && string.trim(type) != "")
     {
+      var disableOnEditing = PreferencesProviderFields.data? true: false;
+      PreferencesProviderFields.name.set("disabled", disableOnEditing);
+      PreferencesProviderFields.type.set("disabled", disableOnEditing);
       if (PreferencesProviderFields.currentType != type)
       {
         require(["qpid/management/authenticationprovider/preferences/" + type.toLowerCase() + "/add"],
@@ -58,9 +61,6 @@ define(["dojo/_base/xhr",
           {
             PreferencesProviderFields.details.destroy();
           }
-          var disableOnEditing = PreferencesProviderFields.data? true: false;
-          PreferencesProviderFields.name.set("disabled", disableOnEditing);
-          PreferencesProviderFields.type.set("disabled", disableOnEditing);
           PreferencesProviderFields.details = typeFields;
           typeFields.show(PreferencesProviderFields.fieldsContainer, PreferencesProviderFields.data);
           PreferencesProviderFields.currentType = type;
@@ -68,7 +68,7 @@ define(["dojo/_base/xhr",
       }
       else
       {
-        PreferencesProviderFields.disable(false);
+        PreferencesProviderFields.details.disable(false);
       }
     }
     else

Modified: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/UserPreferences.js
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/UserPreferences.js?rev=1531965&r1=1531964&r2=1531965&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/UserPreferences.js (original)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/UserPreferences.js Mon Oct 14 16:16:15 2013
@@ -29,6 +29,9 @@ define(["dojo/_base/xhr",
 
   var UserPreferences = {
 
+    /* set time zone to 'UTC' by default*/
+    timeZone: "UTC",
+
     loadPreferences : function(callbackSuccessFunction, callbackErrorFunction)
     {
       var that = this;

Modified: qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/logs/LogViewer.js
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/logs/LogViewer.js?rev=1531965&r1=1531964&r2=1531965&view=diff
==============================================================================
--- qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/logs/LogViewer.js (original)
+++ qpid/trunk/qpid/java/broker-plugins/management-http/src/main/java/resources/js/qpid/management/logs/LogViewer.js Mon Oct 14 16:16:15 2013
@@ -154,7 +154,7 @@ define(["dojo/_base/xhr",
                      sortFields: [{attribute: 'id', descending: true}],
                      plugins:{
                        nestedSorting:true,
-                       enhancedFilter:{defaulGridRowLimit: defaulGridRowLimit},
+                       enhancedFilter:{defaulGridRowLimit: defaulGridRowLimit,displayLastUpdateTime:true},
                        indirectSelection: false,
                        pagination: {defaultPageSize: 10}
                      }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org