You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rambleraptor (via GitHub)" <gi...@apache.org> on 2026/06/02 17:53:23 UTC
[PR] Relative paths for data files [iceberg]
rambleraptor opened a new pull request, #16666:
URL: https://github.com/apache/iceberg/pull/16666
This adds support for reading data files using relative paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Relative paths for data files [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16666:
URL: https://github.com/apache/iceberg/pull/16666#issuecomment-4930861370
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Relative paths for data files [iceberg]
Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on PR #16666:
URL: https://github.com/apache/iceberg/pull/16666#issuecomment-4615084734
@talatuyarer @danielcweeks as the relative paths gurus, please take a look!
@anoopj I know you've been doing work in the space as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Relative paths for data files [iceberg]
Posted by "anoopj (via GitHub)" <gi...@apache.org>.
anoopj commented on code in PR #16666:
URL: https://github.com/apache/iceberg/pull/16666#discussion_r3384622022
##########
core/src/main/java/org/apache/iceberg/InheritableMetadataFactory.java:
##########
@@ -86,6 +98,9 @@ public <F extends ContentFile<F>> ManifestEntry<F> apply(ManifestEntry<F> manife
file.setDataSequenceNumber(manifestEntry.dataSequenceNumber());
file.setFileSequenceNumber(manifestEntry.fileSequenceNumber());
file.setManifestLocation(manifestLocation);
+ if (baseLocation != null && file.path() != null) {
+ file.setLocation(LocationUtil.resolveLocation(baseLocation, file.location()));
Review Comment:
I'm not certain, but I suspect this might cause manifest rewrite paths to always persist the absolute location. (Appends paths would be fine). I guess the tests are probably passing because the v3 paths are always absolute.
##########
core/src/main/java/org/apache/iceberg/BaseFile.java:
##########
@@ -280,6 +280,10 @@ void setManifestLocation(String manifestLocation) {
this.manifestLocation = manifestLocation;
}
+ void setLocation(String location) {
Review Comment:
This is an open design question, but I think `BaseFile` is probably not the correct place to inject the location since we want to isolate this to v4-only code paths. Most likely, we will do the path resolution/relativization in the v4-only adapter layer, as done in this [prototype](https://github.com/apache/iceberg/pull/16150).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Relative paths for data files [iceberg]
Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on PR #16666:
URL: https://github.com/apache/iceberg/pull/16666#issuecomment-4606077907
@talatuyarer ptal!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Relative paths for data files [iceberg]
Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on PR #16666:
URL: https://github.com/apache/iceberg/pull/16666#issuecomment-5334892542
Great, I'll close this out. Thanks for the work on the v4 reader!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Relative paths for data files [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16666:
URL: https://github.com/apache/iceberg/pull/16666#issuecomment-5310408085
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Relative paths for data files [iceberg]
Posted by "anoopj (via GitHub)" <gi...@apache.org>.
anoopj commented on PR #16666:
URL: https://github.com/apache/iceberg/pull/16666#issuecomment-5311335005
https://github.com/apache/iceberg/pull/17434 handles it at the v4 reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core: Relative paths for data files [iceberg]
Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor closed pull request #16666: Core: Relative paths for data files
URL: https://github.com/apache/iceberg/pull/16666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org