You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by lu...@apache.org on 2022/06/13 12:24:25 UTC

[tvm] branch main updated: Added a docstring to missing CMSIS-NN test (#11690)

This is an automated email from the ASF dual-hosted git repository.

lukhut pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git


The following commit(s) were added to refs/heads/main by this push:
     new 2a5ff18bc5 Added a docstring to missing CMSIS-NN test (#11690)
2a5ff18bc5 is described below

commit 2a5ff18bc5a6c466364270bba33a4462be7570e2
Author: Ashutosh Parkhi <86...@users.noreply.github.com>
AuthorDate: Mon Jun 13 13:24:18 2022 +0100

    Added a docstring to missing CMSIS-NN test (#11690)
    
    * Made CMSIS-NN tests pylint compliant
    
    Change-Id: I6bc536a80a24a1603e9f75f8ee9a26d0d88f10df
    
    * Removed comments that disabled pylint checks
    
    Change-Id: Iee513a4a5bef1db5b78e1d25a30ac7202f8b0e92
    
    * Fixed pylint issue in the generate_constants test
    
    Change-Id: Icd341cf524b331ced1fc7ef282b67296583b0fa4
---
 tests/python/contrib/test_cmsisnn/test_generate_constants.py | 1 +
 tests/python/contrib/test_cmsisnn/utils.py                   | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/python/contrib/test_cmsisnn/test_generate_constants.py b/tests/python/contrib/test_cmsisnn/test_generate_constants.py
index e6faa1a243..86737370bc 100644
--- a/tests/python/contrib/test_cmsisnn/test_generate_constants.py
+++ b/tests/python/contrib/test_cmsisnn/test_generate_constants.py
@@ -51,6 +51,7 @@ class CheckGeneratedConstants(tvm.relay.ExprVisitor):
         self.shift_ = shift
 
     def visit_call(self, call):
+        """Tests if the multiplier and shift constants required by CMSIS-NN API were generated"""
         super().visit_call(call)
         if isinstance(call.op, tvm.ir.expr.GlobalVar):
             multiplier = call.args[2]
diff --git a/tests/python/contrib/test_cmsisnn/utils.py b/tests/python/contrib/test_cmsisnn/utils.py
index e69329ebc5..9cd15988c1 100644
--- a/tests/python/contrib/test_cmsisnn/utils.py
+++ b/tests/python/contrib/test_cmsisnn/utils.py
@@ -224,5 +224,4 @@ def make_qnn_relu(expr, fused_activation_fn, scale, zero_point, dtype):
         )
     if fused_activation_fn == "RELU":
         return tvm.relay.op.clip(expr, a_min=max(qmin, quantize(0.0)), a_max=qmax)
-
     raise ValueError("Invalid argument provided with fused_activation_fn")