[GitHub] francois-berder commented on a change in pull request #474: PIC32: Fix stack align

[gi...@git.apache.org]

francois-berder commented on a change in pull request #474: PIC32: Fix stack align
URL: https://github.com/apache/mynewt-core/pull/474#discussion_r130709046
 
 

 ##########
 File path: kernel/os/include/os/arch/pic32/os/os_arch.h
 ##########
 @@ -38,7 +38,8 @@ typedef uint32_t os_sr_t;
 /* Stack type, aligned to a 32-bit word. */
 #define OS_STACK_PATTERN    (0xdeadbeef)
 
-typedef uint32_t os_stack_t;
+/* uint64_t in an attempt to get the stack 8 aligned */
+typedef uint64_t os_stack_t;
 
 Review comment:
   What about :
   ```c
   typedef uint32_t __attribute__((aligned(8))) os_stack_t;
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services