You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by jayapalu <gi...@git.apache.org> on 2015/07/09 06:23:27 UTC
[GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/568
dhcp/dns offload feature config dirve changes for vm migration
Added vm migration changes for config drive.
Added integration test for this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cloudstack dhcpnew
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/568.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #568
----
commit 638885a9de0fd651351f0b16cbdd9fc30c4a187d
Author: Jayapal <ja...@apache.org>
Date: 2015-06-09T10:43:21Z
CLOUDSTACK-8324: Added migration changes for config drive
commit 56f2b9c0b54afe95333612b52e0ea994bae8782d
Author: Jayapal <ja...@apache.org>
Date: 2015-07-01T08:49:20Z
Removed using config drive label from the uservmservice
commit 50efd1da84cf7589a9c8584dbcb3087bd609f404
Author: Jayapal <ja...@apache.org>
Date: 2015-07-02T04:26:58Z
Fixed config key in multiple places
commit 05d8ba1bca2cecef8a79e80a4d64b416115565d6
Author: Jayapal <ja...@apache.org>
Date: 2015-07-08T09:44:46Z
CLOUDSTACK-8324: Added integration tests for dhcp dns offload feature
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: dhcp/dns offload feature config
dirve cha...
Posted by Daan Hoogland <da...@gmail.com>.
my bad, I would like to see "$LGTM" (as in on the start of a line),
though. This looks like a comment at first.
On Fri, Jul 10, 2015 at 3:42 PM, sateesh-chodapuneedi
<gi...@git.apache.org> wrote:
> Github user sateesh-chodapuneedi commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/568#issuecomment-120414615
>
> @DaanHoogland
>
> I think there are 2 LGTM on this one - from @sanju1010 & @kishankavala
>
> > sanju1010 added a note a day ago
> > Need to comment this if DHCP Server is available in the shared network broadcast domain while >running tests. Looks good to me.
>
> >kishankavala commented a day ago
> >Looks good to me.
> >Commented on older PR earlier.
> >PR #552 can be removed
>
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
--
Daan
[GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...
Posted by sateesh-chodapuneedi <gi...@git.apache.org>.
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/568#issuecomment-120414615
@DaanHoogland
I think there are 2 LGTM on this one - from @sanju1010 & @kishankavala
> sanju1010 added a note a day ago
> Need to comment this if DHCP Server is available in the shared network broadcast domain while >running tests. Looks good to me.
>kishankavala commented a day ago
>Looks good to me.
>Commented on older PR earlier.
>PR #552 can be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: dhcp/dns offload feature config
dirve cha...
Posted by Daan Hoogland <da...@gmail.com>.
I don't see two LGTM on this one. What happened?
On Fri, Jul 10, 2015 at 6:20 AM, asfgit <gi...@git.apache.org> wrote:
> Github user asfgit closed the pull request at:
>
> https://github.com/apache/cloudstack/pull/568
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
--
Daan
[GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/568
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...
Posted by kishankavala <gi...@git.apache.org>.
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/568#issuecomment-119917422
Looks good to me.
Commented on older PR earlier.
PR https://github.com/apache/cloudstack/pull/552 can be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/568#discussion_r34226433
--- Diff: test/integration/component/test_dhcp_dns_offload.py ---
@@ -0,0 +1,2126 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Tests for DHCP DNS offload feature
+"""
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.utils import (random_gen, validateList, cleanup_resources, get_hypervisor_type)
+from marvin.lib.base import (Account,
+ NIC,
+ ServiceOffering,
+ DiskOffering,
+ VirtualMachine,
+ Network,
+ NetworkOffering,
+ Configurations,
+ Host,
+ Template,
+ SSHKeyPair,
+ Router)
+from marvin.lib.common import (get_zone,
+ get_template,
+ get_domain
+ )
+from nose.plugins.attrib import attr
+from marvin.codes import PASS,FAIL
+from random import randint
+import random,string,time,tempfile,os,re
+
+@unittest.skip("Skipping dhcp-dns-offload tests for now, since it requires external dhcp server")
--- End diff --
Need to comment this if DHCP Server is available in the shared network broadcast domain while running tests. Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---