You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mintsweet (via GitHub)" <gi...@apache.org> on 2023/02/23 06:21:20 UTC
[GitHub] [incubator-devlake] mintsweet opened a new pull request, #4504: feat(config-ui): support plugin azure devops
mintsweet opened a new pull request, #4504:
URL: https://github.com/apache/incubator-devlake/pull/4504
### Summary
What does this PR do?
### Does this close any open issues?
Closes xx
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] CamilleTeruel commented on a diff in pull request #4504: feat(config-ui): support plugin azure devops
Posted by "CamilleTeruel (via GitHub)" <gi...@apache.org>.
CamilleTeruel commented on code in PR #4504:
URL: https://github.com/apache/incubator-devlake/pull/4504#discussion_r1154315506
##########
backend/server/services/remote/plugin/connection_api.go:
##########
@@ -33,7 +33,7 @@ func (pa *pluginAPI) TestConnection(input *plugin.ApiResourceInput) (*plugin.Api
Success: false,
Message: err.Error(),
}
- return &plugin.ApiResourceOutput{Body: body, Status: 401}, nil
+ return &plugin.ApiResourceOutput{Body: body, Status: 500}, nil
Review Comment:
It is true that the error can be a server error, but it is more regularly an authorization error from the tool API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] CamilleTeruel commented on a diff in pull request #4504: feat(config-ui): support plugin azure devops
Posted by "CamilleTeruel (via GitHub)" <gi...@apache.org>.
CamilleTeruel commented on code in PR #4504:
URL: https://github.com/apache/incubator-devlake/pull/4504#discussion_r1154312547
##########
backend/server/services/remote/bridge/cmd.go:
##########
@@ -71,7 +71,7 @@ func (c *CmdInvoker) Call(methodName string, ctx plugin.ExecContext, args ...any
err = response.GetError()
if err != nil {
return &CallResult{
- Err: errors.Default.Wrap(err, fmt.Sprintf("failed to invoke remote function \"%s\"", methodName)),
+ Err: errors.Default.Wrap(err, fmt.Sprintf("get error when invoking remote function %s", methodName)),
Review Comment:
get -> got
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh merged pull request #4504: feat(config-ui): support plugin azure devops
Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh merged PR #4504:
URL: https://github.com/apache/incubator-devlake/pull/4504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org