You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/08 07:59:45 UTC

[GitHub] [hudi] RexXiong opened a new pull request, #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

RexXiong opened a new pull request, #5264:
URL: https://github.com/apache/hudi/pull/5264

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *  This pr is to solve the problem that hudi incorrectly generates the key of the bytes column value, More details could be found in [HUDI-3818](https://issues.apache.org/jira/browse/HUDI-3818).
   
   ## Brief change log
   
   * encode bytes column value which are represented as bytebuffer
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] bvaradar commented on pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #5264:
URL: https://github.com/apache/hudi/pull/5264#issuecomment-1435479308

   @RexXiong : Thanks a lot for the PR. It looks like this is fixed in master. Will close this PR. Looking forward to more of your contributions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5264:
URL: https://github.com/apache/hudi/pull/5264#issuecomment-1096071253

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "550ed6f6f39b1505e835e989d96be3c674120015",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7916",
       "triggerID" : "550ed6f6f39b1505e835e989d96be3c674120015",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e9ea015b4417b01600dba6985602f0c66e56c666",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e9ea015b4417b01600dba6985602f0c66e56c666",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 550ed6f6f39b1505e835e989d96be3c674120015 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7916) 
   * e9ea015b4417b01600dba6985602f0c66e56c666 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RexXiong commented on pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

Posted by GitBox <gi...@apache.org>.
RexXiong commented on PR #5264:
URL: https://github.com/apache/hudi/pull/5264#issuecomment-1103715740

   >  Same as this  [use case ](https://stackoverflow.com/questions/15360245/when-using-uuids-should-i-also-use-auto-increment) , our hudi user also uses mysql UUID and stored as a BINARY(16) primary key.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] bvaradar commented on pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #5264:
URL: https://github.com/apache/hudi/pull/5264#issuecomment-1435478652

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5264:
URL: https://github.com/apache/hudi/pull/5264#issuecomment-1092571999

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "550ed6f6f39b1505e835e989d96be3c674120015",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7916",
       "triggerID" : "550ed6f6f39b1505e835e989d96be3c674120015",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 550ed6f6f39b1505e835e989d96be3c674120015 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7916) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5264:
URL: https://github.com/apache/hudi/pull/5264#issuecomment-1096262951

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "550ed6f6f39b1505e835e989d96be3c674120015",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7916",
       "triggerID" : "550ed6f6f39b1505e835e989d96be3c674120015",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e9ea015b4417b01600dba6985602f0c66e56c666",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8001",
       "triggerID" : "e9ea015b4417b01600dba6985602f0c66e56c666",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e9ea015b4417b01600dba6985602f0c66e56c666 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8001) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] bvaradar commented on pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #5264:
URL: https://github.com/apache/hudi/pull/5264#issuecomment-1435478601

    byte[] keys are present in CDC scenarios. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5264:
URL: https://github.com/apache/hudi/pull/5264#issuecomment-1092569017

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "550ed6f6f39b1505e835e989d96be3c674120015",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "550ed6f6f39b1505e835e989d96be3c674120015",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 550ed6f6f39b1505e835e989d96be3c674120015 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5264:
URL: https://github.com/apache/hudi/pull/5264#issuecomment-1092658442

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "550ed6f6f39b1505e835e989d96be3c674120015",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7916",
       "triggerID" : "550ed6f6f39b1505e835e989d96be3c674120015",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 550ed6f6f39b1505e835e989d96be3c674120015 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7916) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5264:
URL: https://github.com/apache/hudi/pull/5264#issuecomment-1096075189

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "550ed6f6f39b1505e835e989d96be3c674120015",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7916",
       "triggerID" : "550ed6f6f39b1505e835e989d96be3c674120015",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e9ea015b4417b01600dba6985602f0c66e56c666",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8001",
       "triggerID" : "e9ea015b4417b01600dba6985602f0c66e56c666",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 550ed6f6f39b1505e835e989d96be3c674120015 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7916) 
   * e9ea015b4417b01600dba6985602f0c66e56c666 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8001) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5264:
URL: https://github.com/apache/hudi/pull/5264#issuecomment-1100297837

   generally record key, partition path and precombine should be comparable and so likely primitive types. wondering whats the use-case which demands byte[] to be chosen as a field for record key or partition path. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] bvaradar closed pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey

Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar closed pull request #5264: [HUDI-3818] encode bytes column value when generate HoodieKey
URL: https://github.com/apache/hudi/pull/5264


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org