You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/26 00:18:49 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39211: [CONNECT][MINOR] Move generate_protos.sh to dev/

HyukjinKwon commented on code in PR #39211:
URL: https://github.com/apache/spark/pull/39211#discussion_r1057012438


##########
dev/generate_protos.sh:
##########
@@ -36,7 +36,7 @@ if [[ $# -eq 1 ]]; then
   OUTPUT_PATH=$1
 fi
 
-pushd connector/connect/common/src/main
+pushd ${SPARK_HOME}/connector/connect/common/src/main

Review Comment:
   Should probably put them in quotes in case SPARK_HOME has a space



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org