You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by sohami <gi...@git.apache.org> on 2016/10/06 01:16:23 UTC

[GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/565#discussion_r82102648
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java ---
    @@ -53,6 +54,8 @@ public BootStrapContext(DrillConfig config, ScanResult classpathScan) {
         this.loop2 = TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.BIT_SERVER_RPC_THREADS), "BitClient-");
         // Note that metrics are stored in a static instance
         this.metrics = DrillMetrics.getRegistry();
    +    this.userLoopGroup = TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.USER_SERVER_RPC_THREADS),
    --- End diff --
    
    Please add a comment here stating that "userLoopGroup" threads will be used for "UserServerRPCThreads" and "ClientRPCThreads" in WebServer DrillClient instance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---