You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by bimargulies <gi...@git.apache.org> on 2015/08/12 19:40:21 UTC
[GitHub] httpclient pull request: HTTPCLIENT-1673: revert change, which was...
GitHub user bimargulies opened a pull request:
https://github.com/apache/httpclient/pull/34
HTTPCLIENT-1673: revert change, which was not necessary
and add test that proves that it's not necessary.
Mostly provide bones of future OSGi tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bimargulies/httpclient httpclient-1673-osgi-exports
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit 8031af51d90d179a0978032f20db716d6128b080
Author: Benson Margulies <be...@basistech.com>
Date: 2015-08-12T17:39:00Z
HTTPCLIENT-1673: revert change, which was not necessary
and add test that proves that it's not necessary.
Mostly provide bones of future OSGi tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient pull request: HTTPCLIENT-1673: revert change, which was...
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the pull request:
https://github.com/apache/httpclient/pull/34#issuecomment-131556296
Changes committed to SVN trunk and 4.5.x branch. Many thanks, Benson, for contributing them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient pull request: HTTPCLIENT-1673: revert change, which was...
Posted by bimargulies <gi...@git.apache.org>.
Github user bimargulies commented on the pull request:
https://github.com/apache/httpclient/pull/34#issuecomment-131917206
I am offline until tomorrow.
On Aug 17, 2015 10:11 AM, "Oleg Kalnichevski" <no...@github.com>
wrote:
> Hi Benson,
> There turned out to be a complication with the patch. It looks like some
> of the dependencies introduced by the patch required Java 1.7 or newer.
> Ideally HC 4.5 build should be fully Java 1.6 compatible.
>
> Is there any chance to downgrade those dependencies to older versions
> compatible with Java 1.6?
>
> [JENKINS] Recording test results
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache HttpComponents Client ...................... SUCCESS [43.447s]
> [INFO] Apache HttpClient ................................. SUCCESS [2:58.957s]
> [INFO] Apache HttpClient Mime ............................ SUCCESS [26.083s]
> [INFO] Apache HttpClient Fluent API ...................... SUCCESS [22.008s]
> [INFO] Apache HttpClient Cache ........................... SUCCESS [1:03.547s]
> [INFO] Apache HttpClient Windows features ................ SUCCESS [39.280s]
> [INFO] Apache HttpClient OSGi bundle ..................... FAILURE [1:15.085s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 8:02.812s
> [INFO] Finished at: Mon Aug 17 13:11:51 GMT+00:00 2015
> [INFO] Final Memory: 63M/833M
> [INFO] ------------------------------------------------------------------------
> Waiting for Jenkins to finish collecting data
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:integration-test (default) on project httpclient-osgi: Execution default of goal org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:integration-test failed: There was an error in the forked process
> [ERROR] java.lang.UnsupportedClassVersionError: org/ops4j/pax/exam/Option : Unsupported major.minor version 51.0
> [ERROR] at java.lang.ClassLoader.defineClass1(Native Method)
> [ERROR] at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
> [ERROR] at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
> [ERROR] at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
> [ERROR] at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
> [ERROR] at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
> [ERROR] at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
> [ERROR] at java.security.AccessController.doPrivileged(Native Method)
> [ERROR] at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
> [ERROR] at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
> [ERROR] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
> [ERROR] at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
> [ERROR] at java.lang.Class.getDeclaredMethods0(Native Method)
> [ERROR] at java.lang.Class.privateGetDeclaredMethods(Class.java:2427)
> [ERROR] at java.lang.Class.getMethod0(Class.java:2670)
> [ERROR] at java.lang.Class.getMethod(Class.java:1603)
> [ERROR] at org.apache.maven.surefire.util.ReflectionUtils.tryGetMethod(ReflectionUtils.java:57)
> [ERROR] at org.apache.maven.surefire.common.junit3.JUnit3TestChecker.isSuiteOnly(JUnit3TestChecker.java:64)
> [ERROR] at org.apache.maven.surefire.common.junit3.JUnit3TestChecker.isValidJUnit3Test(JUnit3TestChecker.java:59)
> [ERROR] at org.apache.maven.surefire.common.junit3.JUnit3TestChecker.accept(JUnit3TestChecker.java:54)
> [ERROR] at org.apache.maven.surefire.common.junit4.JUnit4TestChecker.accept(JUnit4TestChecker.java:52)
> [ERROR] at org.apache.maven.surefire.util.DefaultScanResult.applyFilter(DefaultScanResult.java:97)
> [ERROR] at org.apache.maven.surefire.junit4.JUnit4Provider.scanClassPath(JUnit4Provider.java:222)
> [ERROR] at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:107)
> [ERROR] at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
> [ERROR] at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
> [ERROR] at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please read the following articles:
> [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the command
> [ERROR] mvn <goals> -rf :httpclient-osgi
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/httpclient/pull/34#issuecomment-131831413>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpclient pull request: HTTPCLIENT-1673: revert change, which was...
Posted by ok2c <gi...@git.apache.org>.
Github user ok2c commented on the pull request:
https://github.com/apache/httpclient/pull/34#issuecomment-131831413
Hi Benson,
There turned out to be a complication with the patch. It looks like some of the dependencies introduced by the patch required Java 1.7 or newer. Ideally HC 4.5 build should be fully Java 1.6 compatible.
Is there any chance to downgrade those dependencies to older versions compatible with Java 1.6?
```
[JENKINS] Recording test results
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache HttpComponents Client ...................... SUCCESS [43.447s]
[INFO] Apache HttpClient ................................. SUCCESS [2:58.957s]
[INFO] Apache HttpClient Mime ............................ SUCCESS [26.083s]
[INFO] Apache HttpClient Fluent API ...................... SUCCESS [22.008s]
[INFO] Apache HttpClient Cache ........................... SUCCESS [1:03.547s]
[INFO] Apache HttpClient Windows features ................ SUCCESS [39.280s]
[INFO] Apache HttpClient OSGi bundle ..................... FAILURE [1:15.085s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8:02.812s
[INFO] Finished at: Mon Aug 17 13:11:51 GMT+00:00 2015
[INFO] Final Memory: 63M/833M
[INFO] ------------------------------------------------------------------------
Waiting for Jenkins to finish collecting data
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:integration-test (default) on project httpclient-osgi: Execution default of goal org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:integration-test failed: There was an error in the forked process
[ERROR] java.lang.UnsupportedClassVersionError: org/ops4j/pax/exam/Option : Unsupported major.minor version 51.0
[ERROR] at java.lang.ClassLoader.defineClass1(Native Method)
[ERROR] at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
[ERROR] at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
[ERROR] at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
[ERROR] at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
[ERROR] at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
[ERROR] at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
[ERROR] at java.security.AccessController.doPrivileged(Native Method)
[ERROR] at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
[ERROR] at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
[ERROR] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
[ERROR] at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
[ERROR] at java.lang.Class.getDeclaredMethods0(Native Method)
[ERROR] at java.lang.Class.privateGetDeclaredMethods(Class.java:2427)
[ERROR] at java.lang.Class.getMethod0(Class.java:2670)
[ERROR] at java.lang.Class.getMethod(Class.java:1603)
[ERROR] at org.apache.maven.surefire.util.ReflectionUtils.tryGetMethod(ReflectionUtils.java:57)
[ERROR] at org.apache.maven.surefire.common.junit3.JUnit3TestChecker.isSuiteOnly(JUnit3TestChecker.java:64)
[ERROR] at org.apache.maven.surefire.common.junit3.JUnit3TestChecker.isValidJUnit3Test(JUnit3TestChecker.java:59)
[ERROR] at org.apache.maven.surefire.common.junit3.JUnit3TestChecker.accept(JUnit3TestChecker.java:54)
[ERROR] at org.apache.maven.surefire.common.junit4.JUnit4TestChecker.accept(JUnit4TestChecker.java:52)
[ERROR] at org.apache.maven.surefire.util.DefaultScanResult.applyFilter(DefaultScanResult.java:97)
[ERROR] at org.apache.maven.surefire.junit4.JUnit4Provider.scanClassPath(JUnit4Provider.java:222)
[ERROR] at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:107)
[ERROR] at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
[ERROR] at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
[ERROR] at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :httpclient-osgi
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org