You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/02/06 14:38:11 UTC
Review Request 56329: Log Search Portal time zone selection bug
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56329/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-19878
https://issues.apache.org/jira/browse/AMBARI-19878
Repository: ambari
Description
-------
In the time zone selection box the two CST time zones collide: "Central Standard Time" and "China Standard Time" are both abbreviated as CST, and due to this if the user clicks on the CST button, or moves the mouse over any of these regions, then both of them are highlighted.
Also removed an unused file
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/WorldMapGenerator.js 3462ce8
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/mapdata.json 9d88d40
Diff: https://reviews.apache.org/r/56329/diff/
Testing
-------
Tested on local cluster.
Thanks,
Miklos Gergely
Re: Review Request 56329: Log Search Portal time zone selection bug
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56329/#review164380
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Feb. 6, 2017, 6:21 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56329/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 6:21 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-19878
> https://issues.apache.org/jira/browse/AMBARI-19878
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In the time zone selection box the two CST time zones collide: "Central Standard Time" and "China Standard Time" are both abbreviated as CST, and due to this if the user clicks on the CST button, or moves the mouse over any of these regions, then both of them are highlighted.
>
> Also removed an unused file
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/index.html 2d9ae01
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/daterangepicker/css/daterangepicker.css PRE-CREATION
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/daterangepicker/js/daterangepicker.js PRE-CREATION
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/timezone/WorldMapGenerator.js PRE-CREATION
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/timezone/jstz-1.0.4.min.js PRE-CREATION
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/css/daterangepicker.css 7f1ef54
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js e88b45f
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/WorldMapGenerator.js 3462ce8
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/jstz-1.0.4.min.js 96e3dd8
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/mapdata.json 9d88d40
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/Init.js cc16129
>
> Diff: https://reviews.apache.org/r/56329/diff/
>
>
> Testing
> -------
>
> Tested on local cluster.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 56329: Log Search Portal time zone selection bug
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56329/#review164392
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On Feb. 6, 2017, 6:21 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56329/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 6:21 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-19878
> https://issues.apache.org/jira/browse/AMBARI-19878
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In the time zone selection box the two CST time zones collide: "Central Standard Time" and "China Standard Time" are both abbreviated as CST, and due to this if the user clicks on the CST button, or moves the mouse over any of these regions, then both of them are highlighted.
>
> Also removed an unused file
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/index.html 2d9ae01
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/daterangepicker/css/daterangepicker.css PRE-CREATION
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/daterangepicker/js/daterangepicker.js PRE-CREATION
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/timezone/WorldMapGenerator.js PRE-CREATION
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/timezone/jstz-1.0.4.min.js PRE-CREATION
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/css/daterangepicker.css 7f1ef54
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js e88b45f
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/WorldMapGenerator.js 3462ce8
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/jstz-1.0.4.min.js 96e3dd8
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/mapdata.json 9d88d40
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/Init.js cc16129
>
> Diff: https://reviews.apache.org/r/56329/diff/
>
>
> Testing
> -------
>
> Tested on local cluster.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 56329: Log Search Portal time zone selection bug
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56329/
-----------------------------------------------------------
(Updated Feb. 6, 2017, 6:21 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
Moved modified third party libraries to custom
Bugs: AMBARI-19878
https://issues.apache.org/jira/browse/AMBARI-19878
Repository: ambari
Description
-------
In the time zone selection box the two CST time zones collide: "Central Standard Time" and "China Standard Time" are both abbreviated as CST, and due to this if the user clicks on the CST button, or moves the mouse over any of these regions, then both of them are highlighted.
Also removed an unused file
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/index.html 2d9ae01
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/daterangepicker/css/daterangepicker.css PRE-CREATION
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/daterangepicker/js/daterangepicker.js PRE-CREATION
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/timezone/WorldMapGenerator.js PRE-CREATION
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/custom/timezone/jstz-1.0.4.min.js PRE-CREATION
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/css/daterangepicker.css 7f1ef54
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js e88b45f
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/WorldMapGenerator.js 3462ce8
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/jstz-1.0.4.min.js 96e3dd8
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/mapdata.json 9d88d40
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/Init.js cc16129
Diff: https://reviews.apache.org/r/56329/diff/
Testing
-------
Tested on local cluster.
Thanks,
Miklos Gergely
Re: Review Request 56329: Log Search Portal time zone selection bug
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56329/#review164350
-----------------------------------------------------------
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/WorldMapGenerator.js (line 140)
<https://reviews.apache.org/r/56329/#comment236034>
as this is a 3rd party code (inside the lib), we should put that js code, somewhere else, (e.g.: libs/custom), or maybe you can investigate this more, maybe its already fixed in a newer version (then you will need only to replace that file with the newer one)
- Oliver Szabo
On Feb. 6, 2017, 2:38 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56329/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 2:38 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-19878
> https://issues.apache.org/jira/browse/AMBARI-19878
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In the time zone selection box the two CST time zones collide: "Central Standard Time" and "China Standard Time" are both abbreviated as CST, and due to this if the user clicks on the CST button, or moves the mouse over any of these regions, then both of them are highlighted.
>
> Also removed an unused file
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/WorldMapGenerator.js 3462ce8
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/timezone/mapdata.json 9d88d40
>
> Diff: https://reviews.apache.org/r/56329/diff/
>
>
> Testing
> -------
>
> Tested on local cluster.
>
>
> Thanks,
>
> Miklos Gergely
>
>