You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/20 00:24:21 UTC
[GitHub] [iceberg] jackye1995 opened a new pull request #2842: Doc: refactor engines pages and add link to PrestoDB
jackye1995 opened a new pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842
continuation of #2832
Based on the discussion, proposing a way to refactor engines pages to accommodate more Iceberg support in the future.
@rdblue @electrum please see if this version is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842#issuecomment-883004642
@electrum this page is only there I believe for backwards compatibility, as there is no direct links to it. I can separate them into different pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a change in pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842#discussion_r677813496
##########
File path: site/mkdocs.yml
##########
@@ -36,8 +36,8 @@ plugins:
- redirects:
redirect_maps:
'time-travel.md': 'spark-queries/#time-travel'
- 'presto.md': 'trino.md'
- - markdownextradata
+ 'presto.md': 'prestodb.md'
Review comment:
Based on what @electrum says, it seems to violate the Presto trademark if the link to Presto is linked to Trino. But I think it's also fine to remove it if we go with the current refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842#discussion_r689127729
##########
File path: site/mkdocs.yml
##########
@@ -55,6 +55,7 @@ nav:
- Blogs: blogs.md
- Trademarks: trademarks.md
- How to Release: how-to-release.md
+ - Getting Started: getting-started.md
Review comment:
+1 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] cwsteinbach commented on a change in pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
cwsteinbach commented on a change in pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842#discussion_r690746728
##########
File path: site/docs/index.md
##########
@@ -20,8 +20,7 @@
# 
-**Apache Iceberg is an open table format for huge analytic datasets.** Iceberg adds tables to Trino and Spark that use a high-performance format that works just like a SQL table.
-
+**Apache Iceberg is an open table format for huge analytic datasets.** Iceberg adds tables to compute engines including Spark, Trino, PrestoDB, Flink and Hive using a high-performance format that works just like a SQL table.
Review comment:
s/high-performance format/high-performance table format/
##########
File path: site/docs/trino-prestodb.md
##########
@@ -17,4 +17,11 @@
# Trino (formerly Presto SQL)
-The Iceberg connector is available with Trino. It is feature complete and usage details can be found in the [documentation](https://trino.io/docs/current/connector/iceberg.html)
+The Iceberg connector is available with PrestoSQL, which is rebranded as Trino since January 2021.
Review comment:
The title already states that Trino used to be called Presto SQL, stating it again in the paragraph seems redundant. Please consider replacing this with: "The documentation for Iceberg's Trino connector has moved to the Trino website. Please consult the [Iceberg section](https://trino.io/docs/current/connector/iceberg.html) of the Trino docs for more information."
##########
File path: site/docs/getting-started.md
##########
@@ -17,10 +17,14 @@
# Getting Started
-## Using Iceberg in Spark 3
-
The latest version of Iceberg is [{{ versions.iceberg }}](./releases.md).
+Spark is currently the most feature-rich compute engine for Iceberg operations.
Review comment:
Please consider rewording: "We recommend using Spark to learn Iceberg concepts and features since it is currently the most feature-rich compute engine for Iceberg operations. However, if you prefer to start with a different engine, we ask that you consult the documentation for directions on using Iceberg with other compute engines. This documentation is located under the **Engines** tab."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842#discussion_r689127622
##########
File path: site/mkdocs.yml
##########
@@ -36,8 +36,8 @@ plugins:
- redirects:
redirect_maps:
'time-travel.md': 'spark-queries/#time-travel'
- 'presto.md': 'trino.md'
- - markdownextradata
+ 'presto.md': 'prestodb.md'
Review comment:
I think the redirect is fine because this is respecting the existing redirect. We should not refer to Trino as Presto any more, but I don't think that keeping a permalink (that is not referenced from our content) pointed consistently to the same engine is a violation of the Presto trademark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842#discussion_r689127661
##########
File path: site/docs/prestodb.md
##########
@@ -0,0 +1,20 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# PrestoDB
+
+The Iceberg connector is available with PrestoDB. It is feature complete and usage details can be found in the [documentation](https://prestodb.io/docs/current/connector/iceberg.html)
Review comment:
What is the value of having this page instead of linking to the PrestoDB documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] cwsteinbach merged pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
cwsteinbach merged pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a change in pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
findepi commented on a change in pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842#discussion_r676193289
##########
File path: site/mkdocs.yml
##########
@@ -36,8 +36,8 @@ plugins:
- redirects:
redirect_maps:
'time-travel.md': 'spark-queries/#time-travel'
- 'presto.md': 'trino.md'
- - markdownextradata
+ 'presto.md': 'prestodb.md'
Review comment:
That's a breaking change from content/links perspective.
if you feel the redirect cannot stay, it feels safer to remove it, than change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] cwsteinbach commented on a change in pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
cwsteinbach commented on a change in pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842#discussion_r690746728
##########
File path: site/docs/index.md
##########
@@ -20,8 +20,7 @@
# 
-**Apache Iceberg is an open table format for huge analytic datasets.** Iceberg adds tables to Trino and Spark that use a high-performance format that works just like a SQL table.
-
+**Apache Iceberg is an open table format for huge analytic datasets.** Iceberg adds tables to compute engines including Spark, Trino, PrestoDB, Flink and Hive using a high-performance format that works just like a SQL table.
Review comment:
s/high-performance format/high-performance table format/
##########
File path: site/docs/trino-prestodb.md
##########
@@ -17,4 +17,11 @@
# Trino (formerly Presto SQL)
-The Iceberg connector is available with Trino. It is feature complete and usage details can be found in the [documentation](https://trino.io/docs/current/connector/iceberg.html)
+The Iceberg connector is available with PrestoSQL, which is rebranded as Trino since January 2021.
Review comment:
The title already states that Trino used to be called Presto SQL, stating it again in the paragraph seems redundant. Please consider replacing this with: "The documentation for Iceberg's Trino connector has moved to the Trino website. Please consult the [Iceberg section](https://trino.io/docs/current/connector/iceberg.html) of the Trino docs for more information."
##########
File path: site/docs/getting-started.md
##########
@@ -17,10 +17,14 @@
# Getting Started
-## Using Iceberg in Spark 3
-
The latest version of Iceberg is [{{ versions.iceberg }}](./releases.md).
+Spark is currently the most feature-rich compute engine for Iceberg operations.
Review comment:
Please consider rewording: "We recommend using Spark to learn Iceberg concepts and features since it is currently the most feature-rich compute engine for Iceberg operations. However, if you prefer to start with a different engine, we ask that you consult the documentation for directions on using Iceberg with other compute engines. This documentation is located under the **Engines** tab."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842#issuecomment-883004642
@electrum this page is only there I believe for backwards compatibility, as there is no direct links to it. I can separate them into different pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] cwsteinbach merged pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
cwsteinbach merged pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842#issuecomment-887847557
@rdblue any thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #2842: Doc: refactor engines pages and add link to PrestoDB
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842#issuecomment-883004642
@electrum this page is only there I believe for backwards compatibility, as there is no direct links to it. I can separate them into different pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org