[jira] Created: (AMQ-3168) Broker XSD: boolean attributes should permit value injection via Srping's PropertyPlaceholderConfigurer

["Joe Shisei Niski (JIRA)" <ji...@apache.org>]

Broker XSD: boolean attributes should permit value injection via Srping's PropertyPlaceholderConfigurer
-------------------------------------------------------------------------------------------------------

                 Key: AMQ-3168
                 URL: https://issues.apache.org/jira/browse/AMQ-3168
             Project: ActiveMQ
          Issue Type: Bug
          Components: Broker
    Affects Versions: 5.4.2
         Environment: Linux (tested), probably all
            Reporter: Joe Shisei Niski


i'm working on upgrading from AMQ 5.3.0 to 5.4.2. i'd like to keep schema validation enabled, so i'm carefully re-ordering the elements in activemq.xml.
Our configuration uses PropertyPlaceholderConfigurer to insert values into activemq.xml. One of our configured values is of XSD type "boolean":

        <managementContext>
            <managementContext createConnector="${enableJmx}" connectorPort="${jmxConnectorPort}"/>
        </managementContext>

 i'm seeing this error in the console when i run "activemq/bin/activemq-admin start":

ERROR: java.lang.RuntimeException: Failed to execute start task. Reason: org.springframework.beans.factory.xml.XmlBeanDefinitionStoreException: Line 128 in XML document from class path resource [activemq.xml] is invalid; nested exception is org.xml.sax.SAXParseException: cvc-datatype-valid.1.2.1: '${enableJmx}' is not a valid value for 'boolean'.

Other replacement tokens that precede this in the file don't produce errors, but they're for string or numeric values, not booleans. Issue AMQ-2939 mentions accomodating numeric vbalues in the broker.xsd. It would be very useful to accomodate boolean values as well, for both configurability and backward compatibility with existing configurations.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] [Resolved] (AMQ-3168) Broker XSD: boolean attributes should permit value injection via Srping's PropertyPlaceholderConfigurer

["Dejan Bosanac (Resolved) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQ-3168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dejan Bosanac resolved AMQ-3168.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 5.6.0
         Assignee: Dejan Bosanac

BooleanEditor is now used for createConnector property, which will enable it to be substituted even when schema validation is used. For older versions, you can explicitly turn off schema validation by using config "xbean:activemq.xml?validate=false"
                
> Broker XSD: boolean attributes should permit value injection via Srping's PropertyPlaceholderConfigurer
> -------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-3168
>                 URL: https://issues.apache.org/jira/browse/AMQ-3168
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.4.2
>         Environment: Linux (tested), probably all
>            Reporter: Joe Shisei Niski
>            Assignee: Dejan Bosanac
>             Fix For: 5.6.0
>
>
> i'm working on upgrading from AMQ 5.3.0 to 5.4.2. i'd like to keep schema validation enabled, so i'm carefully re-ordering the elements in activemq.xml.
> Our configuration uses PropertyPlaceholderConfigurer to insert values into activemq.xml. One of our configured values is of XSD type "boolean":
>         <managementContext>
>             <managementContext createConnector="${enableJmx}" connectorPort="${jmxConnectorPort}"/>
>         </managementContext>
>  i'm seeing this error in the console when i run "activemq/bin/activemq-admin start":
> ERROR: java.lang.RuntimeException: Failed to execute start task. Reason: org.springframework.beans.factory.xml.XmlBeanDefinitionStoreException: Line 128 in XML document from class path resource [activemq.xml] is invalid; nested exception is org.xml.sax.SAXParseException: cvc-datatype-valid.1.2.1: '${enableJmx}' is not a valid value for 'boolean'.
> Other replacement tokens that precede this in the file don't produce errors, but they're for string or numeric values, not booleans. Issue AMQ-2939 mentions accomodating numeric vbalues in the broker.xsd. It would be very useful to accomodate boolean values as well, for both configurability and backward compatibility with existing configurations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira