org.apache.nifi.processors.standard.ControlRate Inconsitency between documentation and code

[Dan S <ds...@gmail.com>]

On lines 81-83 for the description of  RATE_CONTROL_ATTRIBUTE_NAME
it states

"The name of an attribute whose values build toward the rate limit if Rate
Control Criteria is set to 'attribute value'. "+ "The value of the
attribute referenced by this property must be a positive integer, or the
FlowFile will be routed to failure. "+ "This value is ignored if Rate
Control Criteria is not set to 'attribute value'. Changing this value
resets the rate counters."

Yes on line 257 it is parsed as a long. Hence the comment on lines 81-83
should indicate a positive long instead of positive integer.

Re: org.apache.nifi.processors.standard.ControlRate Inconsitency between documentation and code

[Joe Witt <jo...@gmail.com>]

Thanks Dan.  Turned it into a Jira [1].  Let us know if you're
interested in submitting a patch for that.  Happy to help you get over
any setup/env hurdles you run into.

https://issues.apache.org/jira/browse/NIFI-796

On Wed, Jul 29, 2015 at 10:21 AM, Dan S <ds...@gmail.com> wrote:
> On lines 81-83 for the description of  RATE_CONTROL_ATTRIBUTE_NAME
> it states
>
> "The name of an attribute whose values build toward the rate limit if Rate
> Control Criteria is set to 'attribute value'. "+ "The value of the
> attribute referenced by this property must be a positive integer, or the
> FlowFile will be routed to failure. "+ "This value is ignored if Rate
> Control Criteria is not set to 'attribute value'. Changing this value
> resets the rate counters."
>
> Yes on line 257 it is parsed as a long. Hence the comment on lines 81-83
> should indicate a positive long instead of positive integer.