You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "UncertaintyDeterminesYou4ndMe (via GitHub)" <gi...@apache.org> on 2026/10/20 05:36:50 UTC
[PR] fix(desktop): scroll a tool's output box on its own [maka]
UncertaintyDeterminesYou4ndMe opened a new pull request, #6185:
URL: https://github.com/apache/maka/pull/6185
Scrolling inside a tool's input or output box also scrolled the conversation around it, and the box drew no scrollbar, so nothing showed that it held more.
**One container per gesture** (vendored GPUI Fast). Every `Div` and `List` scroll listener under the pointer took every wheel event, so nested containers all moved together. The window now records which container holds the current gesture, and scrolling chains the way it does in a browser:
- The innermost container under the pointer that moves along the gesture's axis (the axis of the larger delta) takes the gesture and keeps it until the gesture ends, also once it reaches its end. Scrolling to the bottom of a box does not carry on into the conversation.
- A container that cannot move passes the event outward, so a box already at its end hands the next gesture to the conversation. The vendored GPUI Kit's `ScrollableMask` keeps its rule of handing an event to the container around it at its edge.
- Containers the scroll brings under the pointer leave the gesture alone: scrolling the conversation keeps scrolling it when a box arrives under the pointer.
- A gesture ends with a `Started` phase, a wheel event at another position, or 300 ms in which the holder took none of its events. A trackpad gesture ends on such a pause only after its `Ended` phase, as a finger can rest on the trackpad. Momentum events belong to the gesture.
- Events still propagate, so scrollbars and other wheel listeners see them. A container that scrolls one axis with the wheel's other axis takes no part and behaves as before.
GPUI Kit 0.8.0 (longbridge/gpui-kit#3500) gives its own scroll areas a different rule: the innermost area under the pointer takes every event in the capture phase, at its ends too, and stops it. That would conflict with the `ScrollableMask` chaining in the Kit version vendored here, so this change follows the browser instead; `third-party/gpui-fast/SOURCE.md` notes to revisit it when the vendored Kit moves to 0.8.0 or later.
**Scrollbar.** The box stays `overflow_y_scroll()` with a `Scrollbar` laid over it, which shows while it scrolls as the conversation's does. `overflow_y_scrollbar()` does not work here: gpui-shell's `Scrollable` leaves `max_h` on the content element, so the content never overflows and the box stops scrolling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): scroll a tool's output box on its own [maka]
Posted by "M4n5ter (via GitHub)" <gi...@apache.org>.
M4n5ter merged PR #6185:
URL: https://github.com/apache/maka/pull/6185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org