You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/20 18:53:27 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #14177: ARROW-17693: [C++] Remove string_view backport

pitrou commented on code in PR #14177:
URL: https://github.com/apache/arrow/pull/14177#discussion_r975709804


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1974,9 +1974,8 @@ macro(build_gtest)
   set(dummy ">")
 
   set(GTEST_CMAKE_ARGS
-      ${EP_COMMON_TOOLCHAIN}
+      ${EP_COMMON_CMAKE_ARGS}

Review Comment:
   This is so that CMAKE_CXX_STANDARD is propagated to the GTest build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org