You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/11 03:28:57 UTC
[GitHub] [spark] gengliangwang opened a new pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
gengliangwang opened a new pull request #28796:
URL: https://github.com/apache/spark/pull/28796
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR updates the test case to accept Hadoop 2/3 error message correctly.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
SPARK-31935(#28760) breaks Hadoop 3.2 UT because Hadoop 2 and Hadoop 3 have different exception messages.
In https://github.com/apache/spark/pull/28791, there is one test suite missing the fix
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642396828
```
[error] /home/jenkins/workspace/SparkPullRequestBuilder@6/core/src/main/scala/org/apache/spark/SSLOptions.scala:71: type Server is not a member of object org.eclipse.jetty.util.ssl.SslContextFactory
[error] val sslContextFactory = new SslContextFactory.Server()
[error] ^
[info] No documentation generated with unsuccessful compiler run
[error] one error found
```
It seems to be a different commit. I'll take a look~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642455320
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123813/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642396236
Oh..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28796:
URL: https://github.com/apache/spark/pull/28796#discussion_r438525049
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceSuite.scala
##########
@@ -142,7 +142,8 @@ class DataSourceSuite extends SharedSparkSession with PrivateMethodTester {
val message = intercept[java.io.IOException] {
dataSource invokePrivate checkAndGlobPathIfNecessary(false, false)
}.getMessage
- assert(message.equals("No FileSystem for scheme: nonexistsFs"))
+ val expectMessage = "No FileSystem for scheme nonexistFS"
Review comment:
`nonexistFS` -> `nonexistsFs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #28796:
URL: https://github.com/apache/spark/pull/28796#discussion_r438527195
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceSuite.scala
##########
@@ -142,7 +142,8 @@ class DataSourceSuite extends SharedSparkSession with PrivateMethodTester {
val message = intercept[java.io.IOException] {
dataSource invokePrivate checkAndGlobPathIfNecessary(false, false)
}.getMessage
- assert(message.equals("No FileSystem for scheme: nonexistsFs"))
+ val expectMessage = "No FileSystem for scheme nonexistFS"
Review comment:
I see :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642454863
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642390807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642396556
Is it the same at the last commit, e3bb417?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642454628
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28796:
URL: https://github.com/apache/spark/pull/28796#discussion_r438526402
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceSuite.scala
##########
@@ -142,7 +142,8 @@ class DataSourceSuite extends SharedSparkSession with PrivateMethodTester {
val message = intercept[java.io.IOException] {
dataSource invokePrivate checkAndGlobPathIfNecessary(false, false)
}.getMessage
- assert(message.equals("No FileSystem for scheme: nonexistsFs"))
+ val expectMessage = "No FileSystem for scheme nonexistFS"
Review comment:
Ur, I asked this because this test case fails still.
```
[info] - Data source options should be propagated in method checkAndGlobPathIfNecessary *** FAILED *** (599 milliseconds)
[info] "... for scheme nonexist[sFs]" did not equal "... for scheme nonexist[FS]" (DataSourceSuite.scala:146)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642455306
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642384790
**[Test build #123813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123813/testReport)** for PR 28796 at commit [`036864b`](https://github.com/apache/spark/commit/036864b253a3e99cda36b45c5eced6c3f94fc31e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642454856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642392773
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123814/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28796:
URL: https://github.com/apache/spark/pull/28796#discussion_r438526402
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceSuite.scala
##########
@@ -142,7 +142,8 @@ class DataSourceSuite extends SharedSparkSession with PrivateMethodTester {
val message = intercept[java.io.IOException] {
dataSource invokePrivate checkAndGlobPathIfNecessary(false, false)
}.getMessage
- assert(message.equals("No FileSystem for scheme: nonexistsFs"))
+ val expectMessage = "No FileSystem for scheme nonexistFS"
Review comment:
Ur, I asked this because this test case fail still.
```
[info] - Data source options should be propagated in method checkAndGlobPathIfNecessary *** FAILED *** (599 milliseconds)
[info] "... for scheme nonexist[sFs]" did not equal "... for scheme nonexist[FS]" (DataSourceSuite.scala:146)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642392767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642385174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #28796:
URL: https://github.com/apache/spark/pull/28796#discussion_r438525829
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceSuite.scala
##########
@@ -142,7 +142,8 @@ class DataSourceSuite extends SharedSparkSession with PrivateMethodTester {
val message = intercept[java.io.IOException] {
dataSource invokePrivate checkAndGlobPathIfNecessary(false, false)
}.getMessage
- assert(message.equals("No FileSystem for scheme: nonexistsFs"))
+ val expectMessage = "No FileSystem for scheme nonexistFS"
Review comment:
well, then I would prefer nonExistingFS..I was trying to keep the naming simply.
Let me change them all since you are asking.
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceSuite.scala
##########
@@ -142,7 +142,8 @@ class DataSourceSuite extends SharedSparkSession with PrivateMethodTester {
val message = intercept[java.io.IOException] {
dataSource invokePrivate checkAndGlobPathIfNecessary(false, false)
}.getMessage
- assert(message.equals("No FileSystem for scheme: nonexistsFs"))
+ val expectMessage = "No FileSystem for scheme nonexistFS"
Review comment:
well, then I would prefer nonExistingFS..I was trying to keep the naming simple.
Let me change them all since you are asking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642454856
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642385174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642390537
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642392708
**[Test build #123814 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123814/testReport)** for PR 28796 at commit [`58b5159`](https://github.com/apache/spark/commit/58b51596d6e8b5d61b3b52c54d96b07384dc4498).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642386799
**[Test build #123814 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123814/testReport)** for PR 28796 at commit [`58b5159`](https://github.com/apache/spark/commit/58b51596d6e8b5d61b3b52c54d96b07384dc4498).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642396828
```
[error] /home/jenkins/workspace/SparkPullRequestBuilder@6/core/src/main/scala/org/apache/spark/SSLOptions.scala:71: type Server is not a member of object org.eclipse.jetty.util.ssl.SslContextFactory
[error] val sslContextFactory = new SslContextFactory.Server()
[error] ^
[info] No documentation generated with unsuccessful compiler run
[error] one error found
```
It seems to be a different commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642390537
**[Test build #123818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123818/testReport)** for PR 28796 at commit [`e3bb417`](https://github.com/apache/spark/commit/e3bb417220c3d77e0cba0715fe31438f853e546b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642392767
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28796:
URL: https://github.com/apache/spark/pull/28796
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642397230
Got it. Thanks, @gengliangwang .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642386799
**[Test build #123814 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123814/testReport)** for PR 28796 at commit [`58b5159`](https://github.com/apache/spark/commit/58b51596d6e8b5d61b3b52c54d96b07384dc4498).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28796:
URL: https://github.com/apache/spark/pull/28796#discussion_r438522858
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
##########
@@ -540,7 +540,7 @@ class FileStreamSourceSuite extends FileStreamSourceTest {
val message = intercept[java.io.IOException] {
spark.readStream.option("fs.defaultFS", defaultFs).text(path)
}.getMessage
- assert(message == expectMessage)
+ assert(message.filterNot(Set(':', '"').contains) == expectMessage)
Review comment:
We need to remove `:` at line 539, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642394456
^^^ the document generation error seems not related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642396997
The latest run is ongoing and I don't think the error was related https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123818/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28796:
URL: https://github.com/apache/spark/pull/28796#issuecomment-642390807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28796: [SPARK-31935][SQL][TESTS][FOLLOWUP][test-hadoop3.2] Fix the test case for Hadoop2/3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #28796:
URL: https://github.com/apache/spark/pull/28796#discussion_r438526544
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceSuite.scala
##########
@@ -142,7 +142,8 @@ class DataSourceSuite extends SharedSparkSession with PrivateMethodTester {
val message = intercept[java.io.IOException] {
dataSource invokePrivate checkAndGlobPathIfNecessary(false, false)
}.getMessage
- assert(message.equals("No FileSystem for scheme: nonexistsFs"))
+ val expectMessage = "No FileSystem for scheme nonexistFS"
Review comment:
Actually, I don't care about the naming here if it passes with `-Phadoop-3.2`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org