You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jspwiki.apache.org by ju...@apache.org on 2019/10/10 21:30:34 UTC

[jspwiki] 06/08: use Awaitility instead of relaying on Thread.sleep

This is an automated email from the ASF dual-hosted git repository.

juanpablo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jspwiki.git

commit 4cf5ebdd4ca18bd7b560bcd2b3d79ea9f9f12b4f
Author: juanpablo <ju...@apache.org>
AuthorDate: Thu Oct 10 23:27:31 2019 +0200

    use Awaitility instead of relaying on Thread.sleep
---
 .../org/apache/wiki/providers/CachingProviderTest.java  | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/jspwiki-main/src/test/java/org/apache/wiki/providers/CachingProviderTest.java b/jspwiki-main/src/test/java/org/apache/wiki/providers/CachingProviderTest.java
index 52023e5..5a34e13 100644
--- a/jspwiki-main/src/test/java/org/apache/wiki/providers/CachingProviderTest.java
+++ b/jspwiki-main/src/test/java/org/apache/wiki/providers/CachingProviderTest.java
@@ -19,22 +19,22 @@
 
 package org.apache.wiki.providers;
 
-import java.io.File;
-import java.io.FileWriter;
-import java.io.PrintWriter;
-import java.io.StringReader;
-import java.util.Properties;
-
+import net.sf.ehcache.CacheManager;
 import org.apache.log4j.PropertyConfigurator;
 import org.apache.wiki.TestEngine;
 import org.apache.wiki.WikiPage;
 import org.apache.wiki.util.FileUtil;
+import org.awaitility.Awaitility;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-import net.sf.ehcache.CacheManager;
+import java.io.File;
+import java.io.FileWriter;
+import java.io.PrintWriter;
+import java.io.StringReader;
+import java.util.Properties;
 
 public class CachingProviderTest
 {
@@ -105,8 +105,7 @@ public class CachingProviderTest
         FileUtil.copyContents( new StringReader(content), out );
         out.close();
 
-        Thread.sleep( 4000L ); // Make sure we wait long enough
-
+        Awaitility.await( "testSneakyAdd" ).until( () -> engine.getPage( "Testi" ) != null );
         WikiPage p = engine.getPage( "Testi" );
         Assertions.assertNotNull( p, "page did not exist?" );