You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/29 08:24:48 UTC
[GitHub] [tvm] wrongtest opened a new pull request #9602: [DRIVER] Specify name when build with primfunc
wrongtest opened a new pull request #9602:
URL: https://github.com/apache/tvm/pull/9602
If pass a primfunc into tvm.build(), explicitly pass a function name now take no effect, which seems to be a non-prefered behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest commented on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
wrongtest commented on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-986445199
One thing I miss seems that the default argument for `name` is "default_function" instread of None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-994109325
Thank you so much @wrongtest!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-986101709
@jwfromm Got it. It's possible that some stages in the current compilation workflow doesn't respect the fact that specifying name for IRModule is not useful, but I'm not sure which stages they are. @michalpiszczek if you could help figure out the root of the cause, and fix those stages that will be helpful! Otherwise, I'm going to temporarily remove those warnings and add a TODO in the codebase instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest edited a comment on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
wrongtest edited a comment on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-986445199
One thing I miss seems that the default argument for `name` is "default_function" instead of None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mikepapadim commented on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
mikepapadim commented on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-982814835
LGTM, Yes, name mangling for IRModule doenst make sense at this stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 removed a comment on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
junrushao1994 removed a comment on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-986101709
@jwfromm Got it. It's possible that some stages in the current compilation workflow doesn't respect the fact that specifying name for IRModule is not useful, but I'm not sure which stages they are. @mikepapadim if you could help figure out the root of the cause, and fix those stages that will be helpful! Otherwise, I'm going to temporarily remove those warnings and add a TODO in the codebase instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-988569822
@wrongtest would you like to send a new PR fixing this behavior? Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-982095678
@wrongtest thanks for the change, just CC'd other folks who might have introduced this behavior to review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-986100692
Note that this PR causes the warning `"Specifying name with IRModule input is useless"` to pop up for most compilations using standard workflows. I worry that its going to be confusing to / scare away new users. Would it make sense to remove the warning? @junrushao1994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 edited a comment on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
junrushao1994 edited a comment on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-986101709
@jwfromm Got it. It's possible that some stages in the current compilation workflow doesn't respect the fact that specifying name for IRModule is not useful, but I'm not sure which stages they are. @mikepapadim if you could help figure out the root of the cause, and fix those stages that will be helpful! Otherwise, I'm going to temporarily remove those warnings and add a TODO in the codebase instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mikepapadim commented on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
mikepapadim commented on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-986102416
@junrushao1994 thanks for letting me know. I will take a look and get back to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #9602:
URL: https://github.com/apache/tvm/pull/9602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-986101783
@jwfromm Got it. It's possible that some stages in the current compilation workflow doesn't respect the fact that specifying name for IRModule is not useful, but I'm not sure which stages they are. @mikepapadim if you could help figure out the root of the cause, and fix those stages that will be helpful! Otherwise, I'm going to temporarily remove those warnings and add a TODO in the codebase instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-982095474
cc @electriclilies @mikepapadim @Mousius @leandron I feel like this is a combo of name mangling + build API changes, part of me feels like we should deprecate the behavior of naming the artifacts as part of the compilation API, and instead move this saving the module or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest commented on pull request #9602: [DRIVER] Specify name when build with primfunc
Posted by GitBox <gi...@apache.org>.
wrongtest commented on pull request #9602:
URL: https://github.com/apache/tvm/pull/9602#issuecomment-988603828
@junrushao1994 Hi, I create a follow up here; https://github.com/apache/tvm/pull/9678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org