You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by an...@apache.org on 2019/05/07 13:56:47 UTC

[sling-project-archetype] branch master updated: Removed Bundle Installation Profile as this can cause conflicts

This is an automated email from the ASF dual-hosted git repository.

andysch pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-project-archetype.git


The following commit(s) were added to refs/heads/master by this push:
     new 04d1054  Removed Bundle Installation Profile as this can cause conflicts
04d1054 is described below

commit 04d105420e181131a4d8dccfa59c3cd6abf24963
Author: Andreas Schaefer <ac...@Andreass-iMac.local>
AuthorDate: Tue May 7 06:56:34 2019 -0700

    Removed Bundle Installation Profile as this can cause conflicts
    
    Updated Readme to next release info
---
 README.md                                          |  4 ++--
 .../archetype-resources/core.example/pom.xml       | 23 ------------------
 .../resources/archetype-resources/core/pom.xml     | 27 ++++------------------
 3 files changed, 7 insertions(+), 47 deletions(-)

diff --git a/README.md b/README.md
index 5240d58..e722fe9 100644
--- a/README.md
+++ b/README.md
@@ -5,7 +5,7 @@
 | Version | Description |
 |:--------|:------------|
 |1.0.0    |Initial Release. Do not use anymore as it has issues with handling embedded bundles|
-|1.0.1    |Fixes for the embedded bundles issue and prevents the interactive mode to fail to ask for certain parameters by having no defaults|
+|1.0.2    |Fixes for the embedded bundles issue and prevents the interactive mode to fail to ask for certain parameters by having no defaults|
  
 #### Introduction
 
@@ -64,7 +64,7 @@ You can create a project with this archetype using this command:
 mvn archetype:generate \
    -DarchetypeGroupId=org.apache.sling \
    -DarchetypeArtifactId=sling-project-archetype \
-   -DarchetypeVersion=1.0.1
+   -DarchetypeVersion=1.0.2
 ```
 Maven will then guide you through the configuration process to fill in all the
 properties and then create the project.
diff --git a/src/main/resources/archetype-resources/core.example/pom.xml b/src/main/resources/archetype-resources/core.example/pom.xml
index e1036af..a2c027c 100644
--- a/src/main/resources/archetype-resources/core.example/pom.xml
+++ b/src/main/resources/archetype-resources/core.example/pom.xml
@@ -150,27 +150,4 @@
             <artifactId>junit</artifactId>
         </dependency>
     </dependencies>
-
-    <!--Commented out to avoid accidental deployment -->
-    <!--<profiles>-->
-        <!--<profile>-->
-            <!--<id>autoInstallBundle</id>-->
-            <!--<build>-->
-                <!--<plugins>-->
-                    <!--<plugin>-->
-                        <!--<groupId>org.apache.sling</groupId>-->
-                        <!--<artifactId>maven-sling-plugin</artifactId>-->
-                        <!--<executions>-->
-                            <!--<execution>-->
-                                <!--<id>install-bundle</id>-->
-                                <!--<goals>-->
-                                    <!--<goal>install</goal>-->
-                                <!--</goals>-->
-                            <!--</execution>-->
-                        <!--</executions>-->
-                    <!--</plugin>-->
-                <!--</plugins>-->
-            <!--</build>-->
-        <!--</profile>-->
-    <!--</profiles>-->
 </project>
diff --git a/src/main/resources/archetype-resources/core/pom.xml b/src/main/resources/archetype-resources/core/pom.xml
index e298d91..255bb4c 100644
--- a/src/main/resources/archetype-resources/core/pom.xml
+++ b/src/main/resources/archetype-resources/core/pom.xml
@@ -145,26 +145,9 @@
         </dependency>
     </dependencies>
 
-    <profiles>
-        <!-- ATTENTION: It is highly recomended not to deploy this with this Profile if this Bundle was or will be deployed with the All package -->
-        <profile>
-            <id>autoInstallBundle</id>
-            <build>
-                <plugins>
-                    <plugin>
-                        <groupId>org.apache.sling</groupId>
-                        <artifactId>maven-sling-plugin</artifactId>
-                        <executions>
-                            <execution>
-                                <id>install-bundle</id>
-                                <goals>
-                                    <goal>install</goal>
-                                </goals>
-                            </execution>
-                        </executions>
-                    </plugin>
-                </plugins>
-            </build>
-        </profile>
-    </profiles>
+    <!--
+        Attention: the autoInstallBundle was removed as deploying bundles directly and through a package is causing
+                   issues with updates and can prevent the latest code of a bundle being deployed.
+                   If you know what you are doing then you can use maven-sling-plugin directly from the Maven CLI.
+    -->
 </project>