[GitHub] [jmeter] vlsi commented on a diff in pull request #727: Bug 66269: Add NoThreadClone to HeaderManager to reduce heap utilization

["vlsi (via GitHub)" <gi...@apache.org>]

vlsi commented on code in PR #727:
URL: https://github.com/apache/jmeter/pull/727#discussion_r1190776170


##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/control/HeaderManager.java:
##########
@@ -57,9 +58,19 @@ public HeaderManager() {
         setProperty(new CollectionProperty(HEADERS, new ArrayList<>()));
     }
 
+    private void assertMutable() {
+        if (isRunningVersion()) {
+            throw new IllegalStateException(
+                    "Cannot modify HeaderManager " + getName() + " while test is running. " +
+                            "If you need dynamic headers, prefer using ${...} expressions in your headers."

Review Comment:
   Well, the manual says "Functions and Variables". Do you suggest `If you need dynamic headers, prefer using ${...} functions or variables in your headers`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org