You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "aprimadi (via GitHub)" <gi...@apache.org> on 2023/04/22 07:05:35 UTC

[GitHub] [arrow-datafusion] aprimadi commented on pull request #6088: refactor(sqllogictests): port group by test to sqllogic

aprimadi commented on PR #6088:
URL: https://github.com/apache/arrow-datafusion/pull/6088#issuecomment-1518539872

   Not sure if we should port [group_by_dictionary](https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/group_by.rs#L745) test case @alamb. 
   
   It seems that if we port it into sqllogic, the test would be longer. While doing it programmatically seems to be very concise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org