[GitHub] [airflow] ashb commented on a diff in pull request #25758: Used many-to-many relation for finding attached dataset events.

[GitBox <gi...@apache.org>]

ashb commented on code in PR #25758:
URL: https://github.com/apache/airflow/pull/25758#discussion_r947601322


##########
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##########
@@ -116,43 +115,12 @@ def get_upstream_dataset_events(
             "DAGRun not found",
             detail=f"DAGRun with DAG ID: '{dag_id}' and DagRun ID: '{dag_run_id}' not found",
         )
-    events = _get_upstream_dataset_events(dag_run=dag_run, session=session)
+    events = dag_run.dataset_events

Review Comment:
   The only events on a DagRun are the events that that dag run "consumes" -- DagRuns don't produce datasets.
   
   Perhaps the names should change, but the tests still pass (though I did change them, but I didn't change what dag the event is generated against)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org