You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by wu...@apache.org on 2022/11/19 17:32:21 UTC
[ambari] branch trunk updated: AMBARI-25494: Ambari - Unsafe third-party link (target="_blank") (#3538)
This is an automated email from the ASF dual-hosted git repository.
wuzhiguo pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ambari.git
The following commit(s) were added to refs/heads/trunk by this push:
new 63ba039104 AMBARI-25494: Ambari - Unsafe third-party link (target="_blank") (#3538)
63ba039104 is described below
commit 63ba039104d392ba07cbe2a701a2edd9fc709e20
Author: Yu Hou <52...@qq.com>
AuthorDate: Sun Nov 20 01:32:15 2022 +0800
AMBARI-25494: Ambari - Unsafe third-party link (target="_blank") (#3538)
---
ambari-web/app/assets/index.html | 4 ++--
ambari-web/app/templates/common/about.hbs | 6 +++---
ambari-web/app/templates/main/service/services/hive.hbs | 4 ++--
ambari-web/app/templates/main/service/widgets/create/step1.hbs | 4 ++--
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/ambari-web/app/assets/index.html b/ambari-web/app/assets/index.html
index 539a3e2217..99f1fe0444 100644
--- a/ambari-web/app/assets/index.html
+++ b/ambari-web/app/assets/index.html
@@ -45,8 +45,8 @@
</div>
<footer>
<div class="container footer-links">
- <a data-qa="license-link" href="http://www.apache.org/licenses/LICENSE-2.0" target="_blank">Licensed under the Apache License, Version 2.0</a>.<br>
- <a data-qa="third-party-link" href="/licenses/NOTICE.txt" target="_blank">See third-party tools/resources that Ambari uses and their respective authors</a>
+ <a data-qa="license-link" href="http://www.apache.org/licenses/LICENSE-2.0" target="_blank" rel="noopener noreferrer">Licensed under the Apache License, Version 2.0</a>.<br>
+ <a data-qa="third-party-link" href="/licenses/NOTICE.txt" target="_blank" rel="noopener noreferrer">See third-party tools/resources that Ambari uses and their respective authors</a>
</div>
</footer>
</body>
diff --git a/ambari-web/app/templates/common/about.hbs b/ambari-web/app/templates/common/about.hbs
index 00388c8218..3042765475 100644
--- a/ambari-web/app/templates/common/about.hbs
+++ b/ambari-web/app/templates/common/about.hbs
@@ -27,8 +27,8 @@
{{view.ambariVersion}}
<br />
<br />
- <a href="http://ambari.apache.org/" target="_blank">{{t app.aboutAmbari.getInvolved}}</a>
+ <a href="http://ambari.apache.org/" target="_blank" rel="noopener noreferrer">{{t app.aboutAmbari.getInvolved}}</a>
<br />
- <a href="http://www.apache.org/licenses/LICENSE-2.0" target="_blank">{{t app.aboutAmbari.licensed}}</a>
+ <a href="http://www.apache.org/licenses/LICENSE-2.0" target="_blank" rel="noopener noreferrer">{{t app.aboutAmbari.licensed}}</a>
</div>
-</div>
\ No newline at end of file
+</div>
diff --git a/ambari-web/app/templates/main/service/services/hive.hbs b/ambari-web/app/templates/main/service/services/hive.hbs
index 00ad345c63..7a2d6d720c 100644
--- a/ambari-web/app/templates/main/service/services/hive.hbs
+++ b/ambari-web/app/templates/main/service/services/hive.hbs
@@ -51,9 +51,9 @@
<div class="row">
<div class="col-md-6 summary-label" style="margin-top: 0px;">{{link.label}}</div>
<div class="col-md-6 summary-value">
- <a href="#" target="_blank" {{action goToView link.viewInstance target="controller"}}>{{t app.goToView}}</a>
+ <a href="#" target="_blank" rel="noopener noreferrer" {{action goToView link.viewInstance target="controller"}}>{{t app.goToView}}</a>
</div>
</div>
{{/each}}
</div>
-</div>
\ No newline at end of file
+</div>
diff --git a/ambari-web/app/templates/main/service/widgets/create/step1.hbs b/ambari-web/app/templates/main/service/widgets/create/step1.hbs
index 80fd23fe53..c3d9fc3206 100644
--- a/ambari-web/app/templates/main/service/widgets/create/step1.hbs
+++ b/ambari-web/app/templates/main/service/widgets/create/step1.hbs
@@ -31,7 +31,7 @@
<div class="row">
<div class="col-md-4">
<div class="icon">
- <a class="widget-icon-image" target="_blank"><img {{bindAttr src="option.iconPath"}}></a>
+ <a class="widget-icon-image" target="_blank" rel="noopener noreferrer"><img {{bindAttr src="option.iconPath"}}></a>
</div>
</div>
<div class="label-description col-md-8">
@@ -45,4 +45,4 @@
</div>
</div>
</div>
-</div>
\ No newline at end of file
+</div>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org