[jira] [Commented] (HBASE-12452) Add regular expression based split policy

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-12452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610033#comment-14610033 ] 

Hadoop QA commented on HBASE-12452:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12743033/HBASE-12452-V4.patch
  against master branch at commit 85c278a6a8b25ff86e22c254ffec35e945cd7c66.
  ATTACHMENT ID: 12743033

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14638//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14638//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14638//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14638//console

This message is automatically generated.

> Add regular expression based split policy
> -----------------------------------------
>
>                 Key: HBASE-12452
>                 URL: https://issues.apache.org/jira/browse/HBASE-12452
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: He Liangliang
>            Assignee: He Liangliang
>            Priority: Minor
>         Attachments: HBASE-12452-V2.patch, HBASE-12452-V2.patch, HBASE-12452-V3.patch, HBASE-12452-V3.patch, HBASE-12452-V4.patch, HBASE-12452-V4.patch, HBASE-12452.patch
>
>
> The current DelimitedKeyPrefixRegionSplitPolicy split policy is not flexible enough to describe the split point prefix in some case. A regex based split policy is proposed, for example:
>     ^[^\x00]+\x00[^\x00]+\x00
> means the split point will always be truncated to a prefix at the second \0 char.
> The binary string support is quite useful when the rowkey encoded by a common data access library instead of concatenated manually by application developer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)