You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2026/06/22 14:08:29 UTC
(commons-validator) 01/02: Sort members
This is an automated email from the ASF dual-hosted git repository.
garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git
commit 412c24fc38c4aa387e1618dd3275a7ce17272e5a
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Jun 22 14:07:31 2026 +0000
Sort members
---
.../routines/BigIntegerValidatorTest.java | 38 +++++++++++-----------
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/src/test/java/org/apache/commons/validator/routines/BigIntegerValidatorTest.java b/src/test/java/org/apache/commons/validator/routines/BigIntegerValidatorTest.java
index b1f1304b..227dec06 100644
--- a/src/test/java/org/apache/commons/validator/routines/BigIntegerValidatorTest.java
+++ b/src/test/java/org/apache/commons/validator/routines/BigIntegerValidatorTest.java
@@ -197,25 +197,6 @@ class BigIntegerValidatorTest extends AbstractNumberValidatorTest {
assertFalse(instance.minValue(belowMin, Long.MAX_VALUE));
}
- /**
- * The {@link Number} overloads inherited from the superclass must compare the exact value, not a value narrowed to a long, for BigIntegers outside the long
- * range.
- */
- @Test
- void testNumberRangeOutsideLongRange() {
- final AbstractNumberValidator instance = BigIntegerValidator.getInstance();
- final Number min = BigInteger.valueOf(5);
- final Number max = BigInteger.valueOf(100);
- // 2^63 narrows to Long.MIN_VALUE, which the long-based comparison wrongly reports as below the range
- final Number aboveMax = BigInteger.valueOf(Long.MAX_VALUE).add(BigInteger.ONE);
- assertTrue(instance.minValue(aboveMax, min));
- assertFalse(instance.maxValue(aboveMax, max));
- // 2^64 + 50 narrows to 50, which the long-based comparison wrongly reports as in range
- final Number wrapsIntoRange = BigInteger.ONE.shiftLeft(Long.SIZE).add(BigInteger.valueOf(50));
- assertEquals(50L, wrapsIntoRange.longValue());
- assertFalse(instance.isInRange(wrapsIntoRange, min, max));
- }
-
/**
* The {@link Number} overloads must compare against the exact bound. A non-integer bound was converted with BigInteger.toBigInteger(), which truncates
* towards zero, so a fractional minimum was floored (wrongly admitting a value below it) and a fractional maximum was floored too (wrongly admitting a value
@@ -238,4 +219,23 @@ class BigIntegerValidatorTest extends AbstractNumberValidatorTest {
// -6 <= -5.9 is true
assertTrue(instance.maxValue(BigInteger.valueOf(-6), Double.valueOf(-5.9)));
}
+
+ /**
+ * The {@link Number} overloads inherited from the superclass must compare the exact value, not a value narrowed to a long, for BigIntegers outside the long
+ * range.
+ */
+ @Test
+ void testNumberRangeOutsideLongRange() {
+ final AbstractNumberValidator instance = BigIntegerValidator.getInstance();
+ final Number min = BigInteger.valueOf(5);
+ final Number max = BigInteger.valueOf(100);
+ // 2^63 narrows to Long.MIN_VALUE, which the long-based comparison wrongly reports as below the range
+ final Number aboveMax = BigInteger.valueOf(Long.MAX_VALUE).add(BigInteger.ONE);
+ assertTrue(instance.minValue(aboveMax, min));
+ assertFalse(instance.maxValue(aboveMax, max));
+ // 2^64 + 50 narrows to 50, which the long-based comparison wrongly reports as in range
+ final Number wrapsIntoRange = BigInteger.ONE.shiftLeft(Long.SIZE).add(BigInteger.valueOf(50));
+ assertEquals(50L, wrapsIntoRange.longValue());
+ assertFalse(instance.isInRange(wrapsIntoRange, min, max));
+ }
}