You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by cr...@apache.org on 2001/01/08 01:48:17 UTC

cvs commit: jakarta-struts/web/test html-setters.jsp

craigmcc    01/01/07 16:48:17

  Modified:    src/share/org/apache/struts/taglib/html BaseFieldTag.java
               web/test html-setters.jsp
  Log:
  OK, simple property setters work again (there was a class cast exception
  on numeric data types).  Next step: make sure file uploads still work, and
  then do the nested/indexed stuff.
  
  Revision  Changes    Path
  1.2       +7 -7      jakarta-struts/src/share/org/apache/struts/taglib/html/BaseFieldTag.java
  
  Index: BaseFieldTag.java
  ===================================================================
  RCS file: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/BaseFieldTag.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- BaseFieldTag.java	2001/01/06 21:50:39	1.1
  +++ BaseFieldTag.java	2001/01/08 00:48:17	1.2
  @@ -1,7 +1,7 @@
   /*
  - * $Header: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/BaseFieldTag.java,v 1.1 2001/01/06 21:50:39 mschachter Exp $
  - * $Revision: 1.1 $
  - * $Date: 2001/01/06 21:50:39 $
  + * $Header: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/BaseFieldTag.java,v 1.2 2001/01/08 00:48:17 craigmcc Exp $
  + * $Revision: 1.2 $
  + * $Date: 2001/01/08 00:48:17 $
    *
    * ====================================================================
    *
  @@ -79,7 +79,7 @@
    * Convenience base class for the various input tags for text fields.
    *
    * @author Craig R. McClanahan
  - * @version $Revision: 1.1 $ $Date: 2001/01/06 21:50:39 $
  + * @version $Revision: 1.2 $ $Date: 2001/01/08 00:48:17 $
    */
   
   public abstract class BaseFieldTag extends BaseInputTag {
  @@ -178,9 +178,9 @@
   	    try {
                   String value = "";
                   Object objvalue = PropertyUtils.getProperty(bean, property);
  -                
  -                if (!(objvalue instanceof FormFile)) {
  -                    value = (String) objvalue;
  +                if ((objvalue != null) &&
  +                    !(objvalue instanceof FormFile)) {
  +                    value = objvalue.toString();
                   }
                   if (value == null) {
                       value = "";
  
  
  
  1.2       +2 -5      jakarta-struts/web/test/html-setters.jsp
  
  Index: html-setters.jsp
  ===================================================================
  RCS file: /home/cvs/jakarta-struts/web/test/html-setters.jsp,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- html-setters.jsp	2001/01/08 00:17:43	1.1
  +++ html-setters.jsp	2001/01/08 00:48:17	1.2
  @@ -12,12 +12,9 @@
   <h1>Test struts-html Property Setters</h1>
   </div>
   
  -<jsp:useBean id="setold" scope="session"
  -          class="org.apache.struts.test.TestBean"/>
  -
   Whatever changes you make to properties should be reflected when the page
  -is redisplayed.  Submit the form to update, or go back to the
  -<a href="index.jsp">index.jsp</a> page.
  +is redisplayed.  Press "Save" to update, or "Cancel" to return to the
  +main menu.
   
   <html:form action="html-setters.do">
   <table border="0" width="100%">