You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Leo Li (JIRA)" <ji...@apache.org> on 2007/01/09 11:37:27 UTC

[jira] Created: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

[luni][util]Locale lacks some ISO countries and languages.
----------------------------------------------------------

                 Key: HARMONY-2953
                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
             Project: Harmony
          Issue Type: Bug
            Reporter: Leo Li


public void test()
{
Locale locale = new Locale("an");
assertEquals("arg",locale.getISO3Language());

List<String> languages = Arrays.asList(Locale.getISOLanguages());
assertTrue(languages.contains("ak"));
}


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by "Leo Li (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463240 ] 

Leo Li commented on HARMONY-2953:
---------------------------------

Sorry, made a little mistake. I will give a new patch.

> [luni][util]Locale lacks some ISO countries and languages.
> ----------------------------------------------------------
>
>                 Key: HARMONY-2953
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Attachments: patch-2953.diff
>
>
> public void test()
> {
> Locale locale = new Locale("an");
> assertEquals("arg",locale.getISO3Language());
> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> assertTrue(languages.contains("ak"));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by "Leo Li (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leo Li updated HARMONY-2953:
----------------------------

    Attachment:     (was: patch-2953-new.diff)

> [luni][util]Locale lacks some ISO countries and languages.
> ----------------------------------------------------------
>
>                 Key: HARMONY-2953
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Attachments: patch-2953.diff
>
>
> public void test()
> {
> Locale locale = new Locale("an");
> assertEquals("arg",locale.getISO3Language());
> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> assertTrue(languages.contains("ak"));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by "Leo Li (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464066 ] 

Leo Li commented on HARMONY-2953:
---------------------------------

Thank you ,Tim.
Verified.
I will catch up with it.

Leo.

> [luni][util]Locale lacks some ISO countries and languages.
> ----------------------------------------------------------
>
>                 Key: HARMONY-2953
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Assigned To: Tim Ellison
>         Attachments: patch-2953.diff
>
>
> public void test()
> {
> Locale locale = new Locale("an");
> assertEquals("arg",locale.getISO3Language());
> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> assertTrue(languages.contains("ak"));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] Resolved: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by Yang Paulex <pa...@gmail.com>.
I thought about this and I thought this makes sense, because there are
duplicated data in Harmony now, but I haven't got enough time to
investigate, my gut feeling on the possible issues include:

1. ICU is not designed to be used in bootclasspath, so that we met several
issues related to this, for example, it put the Character upper/lower case
mapping in several data files, which needs to be loaded by
ClassLoader.getResourceAsStream(), while when Harmony VM need to use these
data, the URL hasn't been ready to use yet. I suppose there will be more
issues when we refactor more I18n related functions based on ICU.

2. ICU data has difference with RI's, for historical or other unknown
reasons, either RI's or ICU's data has differences with standard(Unicode,
ISO, etc), it's not so significant in technical perspective, but to be
realistic it causes many compability issues (we already got several still
open in JIRA system).

But still, I think it worths the cost, and actually my only real issue is
time...any other willing to look at this?

2007/1/10, Tim Ellison <t....@gmail.com>:
>
> I have applied Leo's patch to the Locale info to get him working again,
> but the original data in those classes comes from the CLDR.
>
> We can either recreate the Java code based on the latest version of CLDR
> data, or (my preference, though not yet investigated) is to ditch them
> and get the info from the ICU data files that we are already dependent
> upon.
>
> Thoughts?
> Tim
>
>
> Tim Ellison (JIRA) wrote:
> >
> > Tim Ellison resolved HARMONY-2953.
> > ----------------------------------
> >
> >     Resolution: Fixed
> >
> > Thanks Leo.
> >
> > Patch applied to LUNI module at repo revision r494397.
> >
> > Please check that it was applied as you expected.
> >
> >
> > The patch should get you going again, but the locale info is
> > maintained external to the Harmony project, I'll raise a discussion
> > on the dev list about that.
> >
> >
> >> [luni][util]Locale lacks some ISO countries and languages.
> >> ----------------------------------------------------------
> >>
> >>                 Key: HARMONY-2953
> >>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
> >>             Project: Harmony
> >>          Issue Type: Bug
> >>            Reporter: Leo Li
> >>         Assigned To: Tim Ellison
> >>         Attachments: patch-2953.diff
> >>
> >>
> >> public void test()
> >> {
> >> Locale locale = new Locale("an");
> >> assertEquals("arg",locale.getISO3Language());
> >> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> >> assertTrue(languages.contains("ak"));
> >> }
> >
>



-- 
Paulex Yang
China Software Development Labotary
IBM

Re: [jira] Resolved: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by Tim Ellison <t....@gmail.com>.
I have applied Leo's patch to the Locale info to get him working again,
but the original data in those classes comes from the CLDR.

We can either recreate the Java code based on the latest version of CLDR
data, or (my preference, though not yet investigated) is to ditch them
and get the info from the ICU data files that we are already dependent upon.

Thoughts?
Tim


Tim Ellison (JIRA) wrote:
> 
> Tim Ellison resolved HARMONY-2953.
> ----------------------------------
> 
>     Resolution: Fixed
> 
> Thanks Leo.
> 
> Patch applied to LUNI module at repo revision r494397.
> 
> Please check that it was applied as you expected.
> 
>
> The patch should get you going again, but the locale info is
> maintained external to the Harmony project, I'll raise a discussion
> on the dev list about that.
> 
> 
>> [luni][util]Locale lacks some ISO countries and languages.
>> ----------------------------------------------------------
>>
>>                 Key: HARMONY-2953
>>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>>             Project: Harmony
>>          Issue Type: Bug
>>            Reporter: Leo Li
>>         Assigned To: Tim Ellison
>>         Attachments: patch-2953.diff
>>
>>
>> public void test()
>> {
>> Locale locale = new Locale("an");
>> assertEquals("arg",locale.getISO3Language());
>> List<String> languages = Arrays.asList(Locale.getISOLanguages());
>> assertTrue(languages.contains("ak"));
>> }
> 

[jira] Resolved: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison resolved HARMONY-2953.
----------------------------------

    Resolution: Fixed

Thanks Leo.

Patch applied to LUNI module at repo revision r494397.

Please check that it was applied as you expected.

The patch should get you going again, but the locale info is maintained external to the Harmony project, I'll raise a discussion on the dev list about that.


> [luni][util]Locale lacks some ISO countries and languages.
> ----------------------------------------------------------
>
>                 Key: HARMONY-2953
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Assigned To: Tim Ellison
>         Attachments: patch-2953.diff
>
>
> public void test()
> {
> Locale locale = new Locale("an");
> assertEquals("arg",locale.getISO3Language());
> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> assertTrue(languages.contains("ak"));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison closed HARMONY-2953.
--------------------------------


Verified by Leo.


> [luni][util]Locale lacks some ISO countries and languages.
> ----------------------------------------------------------
>
>                 Key: HARMONY-2953
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Assigned To: Tim Ellison
>         Attachments: patch-2953.diff
>
>
> public void test()
> {
> Locale locale = new Locale("an");
> assertEquals("arg",locale.getISO3Language());
> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> assertTrue(languages.contains("ak"));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by "Leo Li (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463242 ] 

Leo Li commented on HARMONY-2953:
---------------------------------

Will somebody try the patch?

Thanks.
Leo.

> [luni][util]Locale lacks some ISO countries and languages.
> ----------------------------------------------------------
>
>                 Key: HARMONY-2953
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Attachments: patch-2953.diff
>
>
> public void test()
> {
> Locale locale = new Locale("an");
> assertEquals("arg",locale.getISO3Language());
> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> assertTrue(languages.contains("ak"));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by "Leo Li (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leo Li updated HARMONY-2953:
----------------------------

    Attachment: patch-2953-new.diff

> [luni][util]Locale lacks some ISO countries and languages.
> ----------------------------------------------------------
>
>                 Key: HARMONY-2953
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Attachments: patch-2953.diff
>
>
> public void test()
> {
> Locale locale = new Locale("an");
> assertEquals("arg",locale.getISO3Language());
> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> assertTrue(languages.contains("ak"));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by "Leo Li (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leo Li updated HARMONY-2953:
----------------------------

    Attachment: patch-2953.diff

> [luni][util]Locale lacks some ISO countries and languages.
> ----------------------------------------------------------
>
>                 Key: HARMONY-2953
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Attachments: patch-2953.diff
>
>
> public void test()
> {
> Locale locale = new Locale("an");
> assertEquals("arg",locale.getISO3Language());
> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> assertTrue(languages.contains("ak"));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by "Leo Li (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leo Li updated HARMONY-2953:
----------------------------

    Attachment: patch-2953.diff

> [luni][util]Locale lacks some ISO countries and languages.
> ----------------------------------------------------------
>
>                 Key: HARMONY-2953
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Attachments: patch-2953.diff
>
>
> public void test()
> {
> Locale locale = new Locale("an");
> assertEquals("arg",locale.getISO3Language());
> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> assertTrue(languages.contains("ak"));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by "Leo Li (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leo Li updated HARMONY-2953:
----------------------------

    Attachment:     (was: patch-2953.diff)

> [luni][util]Locale lacks some ISO countries and languages.
> ----------------------------------------------------------
>
>                 Key: HARMONY-2953
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Attachments: patch-2953.diff
>
>
> public void test()
> {
> Locale locale = new Locale("an");
> assertEquals("arg",locale.getISO3Language());
> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> assertTrue(languages.contains("ak"));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by "Leo Li (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leo Li updated HARMONY-2953:
----------------------------

    Comment: was deleted

> [luni][util]Locale lacks some ISO countries and languages.
> ----------------------------------------------------------
>
>                 Key: HARMONY-2953
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Attachments: patch-2953.diff
>
>
> public void test()
> {
> Locale locale = new Locale("an");
> assertEquals("arg",locale.getISO3Language());
> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> assertTrue(languages.contains("ak"));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-2953) [luni][util]Locale lacks some ISO countries and languages.

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison reassigned HARMONY-2953:
------------------------------------

    Assignee: Tim Ellison

> [luni][util]Locale lacks some ISO countries and languages.
> ----------------------------------------------------------
>
>                 Key: HARMONY-2953
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2953
>             Project: Harmony
>          Issue Type: Bug
>            Reporter: Leo Li
>         Assigned To: Tim Ellison
>         Attachments: patch-2953.diff
>
>
> public void test()
> {
> Locale locale = new Locale("an");
> assertEquals("arg",locale.getISO3Language());
> List<String> languages = Arrays.asList(Locale.getISOLanguages());
> assertTrue(languages.contains("ak"));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira