You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/11/01 23:04:26 UTC
[commons-numbers] 04/06: Unit tests.
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit f27b5da7dea235b2529294fb62ef40589544da52
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Fri Nov 1 23:53:46 2019 +0100
Unit tests.
---
.../commons/numbers/fraction/FractionTest.java | 25 ++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
index 6b867b6..aea3d01 100644
--- a/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
+++ b/commons-numbers-fraction/src/test/java/org/apache/commons/numbers/fraction/FractionTest.java
@@ -504,12 +504,26 @@ public class FractionTest {
public void testParse() {
String[] validExpressions = new String[] {
"1 / 2",
+ "-1 / 2",
+ "1 / -2",
+ "-1 / -2",
+ "01 / 2",
+ "01 / 02",
+ "-01 / 02",
+ "01 / -02",
"15 / 16",
"-2 / 3",
"8 / 7"
};
Fraction[] fractions = {
Fraction.of(1, 2),
+ Fraction.of(-1, 2),
+ Fraction.of(1, -2),
+ Fraction.of(-1, -2),
+ Fraction.of(1, 2),
+ Fraction.of(1, 2),
+ Fraction.of(-1, 2),
+ Fraction.of(1, -2),
Fraction.of(15, 16),
Fraction.of(-2, 3),
Fraction.of(8, 7),
@@ -520,5 +534,16 @@ public class FractionTest {
Fraction.parse(validExpressions[inc]));
inc++;
}
+
+ {
+ Assertions.assertThrows(NumberFormatException.class,
+ () -> Fraction.parse("1 // 2"));
+ Assertions.assertThrows(NumberFormatException.class,
+ () -> Fraction.parse("1 / z"));
+ Assertions.assertThrows(NumberFormatException.class,
+ () -> Fraction.parse("1 / --2"));
+ Assertions.assertThrows(NumberFormatException.class,
+ () -> Fraction.parse("x"));
+ }
}
}