You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/13 00:12:34 UTC

[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #4301: [ISSUE #3962] Fix variable name in MappedFile#isAbleToCommit()

Oliverwqcwrw commented on code in PR #4301:
URL: https://github.com/apache/rocketmq/pull/4301#discussion_r871905083


##########
store/src/main/java/org/apache/rocketmq/store/MappedFile.java:
##########
@@ -371,18 +371,18 @@ private boolean isAbleToFlush(final int flushLeastPages) {
     }
 
     protected boolean isAbleToCommit(final int commitLeastPages) {
-        int flush = this.committedPosition.get();
+        int commit = this.committedPosition.get();

Review Comment:
   I think `flush` is correct,This represents the offset of the flush without changing the variable name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org