You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/04/15 23:48:55 UTC
[GitHub] [cordova-android] breautek opened a new pull request #959: test:
synced androidx gradle versions to the same version as the android test
breautek opened a new pull request #959: test: synced androidx gradle versions to the same version as the android test
URL: https://github.com/apache/cordova-android/pull/959
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Fixes androidx test versions, who was still on gradle 4 and android gradle plugin 3.5.3, inconsistent with its `android` test sibling.
### Description
<!-- Describe your changes in detail -->
Upgrade gradle version pins
### Testing
<!-- Please describe in detail how you tested your changes. -->
Ran `node run_java_unit_tests.js`
Currently `npm test` fails due to some unrelated problem.
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #959: test:
synced androidx gradle versions to the same version as the android test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #959: test: synced androidx gradle versions to the same version as the android test
URL: https://github.com/apache/cordova-android/pull/959#issuecomment-614335758
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=h1) Report
> Merging [#959](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/566262c9239e13f9dbd15235622b3aa8c95e04ed&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #959 +/- ##
==========================================
- Coverage 65.53% 65.48% -0.06%
==========================================
Files 21 21
Lines 1828 1828
==========================================
- Hits 1198 1197 -1
- Misses 630 631 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/959/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.69% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=footer). Last update [566262c...dc9a56c](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #959: test:
synced androidx gradle versions to the same version as the android test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #959: test: synced androidx gradle versions to the same version as the android test
URL: https://github.com/apache/cordova-android/pull/959#issuecomment-614335758
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=h1) Report
> Merging [#959](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/566262c9239e13f9dbd15235622b3aa8c95e04ed&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #959 +/- ##
=======================================
Coverage 65.53% 65.53%
=======================================
Files 21 21
Lines 1828 1828
=======================================
Hits 1198 1198
Misses 630 630
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=footer). Last update [566262c...dc9a56c](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #959: test:
synced androidx gradle versions to the same version as the android test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #959: test: synced androidx gradle versions to the same version as the android test
URL: https://github.com/apache/cordova-android/pull/959#issuecomment-614335758
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=h1) Report
> Merging [#959](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/566262c9239e13f9dbd15235622b3aa8c95e04ed&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #959 +/- ##
=======================================
Coverage 65.53% 65.53%
=======================================
Files 21 21
Lines 1828 1828
=======================================
Hits 1198 1198
Misses 630 630
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=footer). Last update [566262c...dc9a56c](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #959: test:
synced androidx gradle versions to the same version as the android test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #959: test: synced androidx gradle versions to the same version as the android test
URL: https://github.com/apache/cordova-android/pull/959#issuecomment-614335758
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=h1) Report
> Merging [#959](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/566262c9239e13f9dbd15235622b3aa8c95e04ed&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #959 +/- ##
==========================================
- Coverage 65.53% 65.48% -0.06%
==========================================
Files 21 21
Lines 1828 1828
==========================================
- Hits 1198 1197 -1
- Misses 630 631 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/959/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.69% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=footer). Last update [566262c...dc9a56c](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on issue #959: test: synced
androidx gradle versions to the same version as the android test
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #959: test: synced androidx gradle versions to the same version as the android test
URL: https://github.com/apache/cordova-android/pull/959#issuecomment-614335758
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=h1) Report
> Merging [#959](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/566262c9239e13f9dbd15235622b3aa8c95e04ed&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #959 +/- ##
==========================================
- Coverage 65.53% 65.48% -0.06%
==========================================
Files 21 21
Lines 1828 1828
==========================================
- Hits 1198 1197 -1
- Misses 630 631 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/959/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.69% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=footer). Last update [566262c...dc9a56c](https://codecov.io/gh/apache/cordova-android/pull/959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] breautek merged pull request #959: test: synced
androidx gradle versions to the same version as the android test
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #959: test: synced androidx gradle versions to the same version as the android test
URL: https://github.com/apache/cordova-android/pull/959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org