You are viewing a plain text version of this content. The canonical link for it is here.
Posted to discuss-archive@tvm.apache.org by "tlopex (via GitHub)" <gi...@apache.org> on 2026/07/12 20:56:42 UTC

[PR] [Fix][Python] Use standard scikit-build directory [tvm]

tlopex opened a new pull request, #19990:
URL: https://github.com/apache/tvm/pull/19990

   This PR removes `{wheel_tag}` from the scikit-build build directory.
   
   Each cibuildwheel matrix job runs in an isolated environment, so separate tagged build directories are unnecessary. Using `build` restores the existing `build/lib` development layout expected by `tvm.libinfo` and fixes editable installs without adding runtime directory globbing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org


Re: [PR] [Fix][Python] Use standard scikit-build directory [tvm]

Posted by "mshr-h (via GitHub)" <gi...@apache.org>.
mshr-h merged PR #19990:
URL: https://github.com/apache/tvm/pull/19990


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org


Re: [PR] [Fix][Python] Use standard scikit-build directory [tvm]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #19990:
URL: https://github.com/apache/tvm/pull/19990#discussion_r3567108966


##########
pyproject.toml:
##########
@@ -91,7 +91,7 @@ dev = [{ include-group = "test" }, { include-group = "lint" }]
 [tool.scikit-build]
 cmake.build-type = "Release"
 wheel.py-api = "py3"
-build-dir = "build/{wheel_tag}"
+build-dir = "build"

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   Changing `build-dir` to `"build"` can conflict with manual C++ builds. Developers typically build TVM from source by creating a `build` directory at the root and running `cmake ..` with custom configurations (e.g., enabling CUDA, LLVM, etc.).
   
   If they then run `pip install -e .` or `pip install .`, `scikit-build-core` will reconfigure the same `build` directory using the default settings in `pyproject.toml` (which has `USE_CUDA = "OFF"`), overwriting the developer's custom CMake cache and build artifacts.
   
   Consider using a dedicated subdirectory like `build/wheel` to isolate Python wheel builds from manual C++ builds, and update `tvm.libinfo` if necessary to search this path.
   
   ```suggestion
   build-dir = "build/wheel"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org


Re: [PR] [Fix][Python] Use standard scikit-build directory [tvm]

Posted by "mshr-h (via GitHub)" <gi...@apache.org>.
mshr-h commented on PR #19990:
URL: https://github.com/apache/tvm/pull/19990#issuecomment-4953927229

   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org