You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/10 18:33:30 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #7453:
[WIP] Refine table name handling in SQL Lab
codecov-io edited a comment on issue #7453: [WIP] Refine table name handling in SQL Lab
URL: https://github.com/apache/incubator-superset/pull/7453#issuecomment-491389043
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7453?src=pr&el=h1) Report
> Merging [#7453](https://codecov.io/gh/apache/incubator-superset/pull/7453?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/51fd43a47b3ed33df90f4f8ebc7e763517825d02?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `37.03%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7453?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7453 +/- ##
==========================================
+ Coverage 65.42% 65.47% +0.05%
==========================================
Files 435 435
Lines 21323 21328 +5
Branches 2347 2345 -2
==========================================
+ Hits 13950 13965 +15
+ Misses 7257 7247 -10
Partials 116 116
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7453?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/7453/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.01% <0%> (ø)` | :arrow_up: |
| [.../assets/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7453/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3JMZWZ0QmFyLmpzeA==) | `40.42% <0%> (+3.88%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7453/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.21% <100%> (+0.06%)` | :arrow_up: |
| [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7453/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `84.16% <100%> (-0.52%)` | :arrow_down: |
| [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/7453/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `76.39% <100%> (+0.2%)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/7453/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `62.35% <35.71%> (+0.87%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7453/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.74% <69.23%> (+0.28%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7453/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.89% <8%> (-0.1%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7453?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7453?src=pr&el=footer). Last update [51fd43a...5a5af4f](https://codecov.io/gh/apache/incubator-superset/pull/7453?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org