You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/16 14:58:00 UTC

[jira] [Commented] (ARTEMIS-1763) Remove 'quick check' before quorum

    [ https://issues.apache.org/jira/browse/ARTEMIS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439550#comment-16439550 ] 

ASF GitHub Bot commented on ARTEMIS-1763:
-----------------------------------------

GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2021

    NO-JIRA: Fix test regression

    QuorumFailOverTest.testQuorumVotingLiveNotDead fails
    because the quorum vote takes longer time to finish than
    the test expects to.
    (The test used to pass until commit ARTEMIS-1763)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis h_fix_regress

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2021.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2021
    
----
commit 64f974ff52470553de8520ec7b374a78494d861e
Author: Howard Gao <ho...@...>
Date:   2018-04-16T14:02:32Z

    NO-JIRA: Fix test regression
    
    QuorumFailOverTest.testQuorumVotingLiveNotDead fails
    because the quorum vote takes longer time to finish than
    the test expects to.
    (The test used to pass until commit ARTEMIS-1763)

----


> Remove 'quick check' before quorum
> ----------------------------------
>
>                 Key: ARTEMIS-1763
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1763
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Andy Taylor
>            Assignee: Andy Taylor
>            Priority: Major
>             Fix For: 2.5.1
>
>
> A check was added to SharedNothingBackupQuorum in isLiveDown method to quickly check if the backup could still connect to the live. This should be removed as it is unreliable and by passes the actual quorum vote.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)