[GitHub] [mynewt-core] utzig commented on issue #2155: Add travis checking of coding style

[GitBox <gi...@apache.org>]

utzig commented on issue #2155: Add travis checking of coding style
URL: https://github.com/apache/mynewt-core/pull/2155#issuecomment-575262656
 
 
   This should be functional now; the two main issues that remain:
   
   1) It always checks style on whole files, even when the user made only small changes. It would be possible to isolate the specific changed sections by looking at the diff indexes but since those might not provide something that is valid C, I'm not sure how good it would be to try to style check.
   2) There is some issue with alignment of parameters in functions calls. I have not found a way to ignore those, so I left it configured to align parameters that are on different lines below the `(` of the call. This seems to provide better results for our style, although it will be giving a few "false positive" style issues. Hope to fix this soon!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services