You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/22 08:34:05 UTC
[GitHub] [incubator-nuttx-apps] juniskane opened a new pull request #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
juniskane opened a new pull request #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198
Also wget state is now allocated in order to conserve stack space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-618047023
It's #199 actually. I also restarted the checks when I merged it. I guess this PR needs to be rebased.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gregory-nutt commented on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
gregory-nutt commented on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-618061897
>
>
> It's #199 actually. I also restarted the checks when I merged it. I guess this PR needs to be rebased.
We can rebase the branch for Juha, right? I tried but I am not sure how to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-618190438
Yes, the ci check still run on the base when PR submit. @juniskane could you rebase your PR to the latest mainline?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-617797022
> Build is failing because of this? I can't see any other reason:
Because this commit enforce the repo must in clean state after make distclean:
https://github.com/apache/incubator-nuttx-apps/commit/989988fa7203ab5e5d26b140c8a43ddeb41d578e
But the current mainline doesn't fix all issue yet. I will provide a patch temporarily until we clean up the code base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] juniskane edited a comment on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
juniskane edited a comment on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-617710462
Build is failing because of this? I can't see any other reason:
CC frontends/conf/frontends_conf_kconfig_conf-conf.o
frontends/conf/conf.c:78:10: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
printf(_("aborted!\n\n"));
^~~~~~~~~~~~~~~~~
./libs/parser/lkc.h:34:17: note: expanded from macro '_'
#define _(text) gettext(text)
^~~~~~~~~~~~~
frontends/conf/conf.c:78:10: note: treat the string as an argument to avoid this
printf(_("aborted!\n\n"));
^
"%s",
./libs/parser/lkc.h:34:17: note: expanded from macro '_'
#define _(text) gettext(text)
^
frontends/conf/conf.c:79:10: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
printf(_("Console input/output is redirected. "));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libs/parser/lkc.h:34:17: note: expanded from macro '_'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-618036797
> Here is the PR: #198
That is this PR????
I just restarted the PR checks for the 3rd time and it is still failing as it was before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] juniskane commented on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
juniskane commented on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-617710462
Build is failing because of this? I can't see any other reason:
CC frontends/conf/frontends_conf_kconfig_conf-conf.o
frontends/conf/conf.c:78:10: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
printf(_("aborted!\n\n"));
^~~~~~~~~~~~~~~~~
./libs/parser/lkc.h:34:17: note: expanded from macro '_'
#define _(text) gettext(text)
^~~~~~~~~~~~~
frontends/conf/conf.c:78:10: note: treat the string as an argument to avoid this
printf(_("aborted!\n\n"));
^
"%s",
./libs/parser/lkc.h:34:17: note: expanded from macro '_'
#define _(text) gettext(text)
^
frontends/conf/conf.c:79:10: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
printf(_("Console input/output is redirected. "));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./libs/parser/lkc.h:34:17: note: expanded from macro '_'
Also, can we make the style checks optional please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-618427282
github is unstable again:(. We have to rerun it from Checks tab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-618442193
> But now the CI is failing due to Internal Error 500 _sigh_
I've re-started it a few time, but it is still randomly failing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-618194526
> > It's #199 actually. I also restarted the checks when I merged it. I guess this PR needs to be rebased.
>
> We can rebase the branch for Juha, right? I tried but I am not sure how to do that.
Here has the info:
https://github.blog/2016-09-07-improving-collaboration-with-forks/
Basically, you have to clone(remote add) the contributor's repo, modify the patch and push to his repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-617800145
Here is the PR: https://github.com/apache/incubator-nuttx-apps/pull/198
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Ouss4 commented on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-618092904
We can if he wants to. That would require force pushing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-617797022
> Build is failing because of this? I can't see any other reason:
Because this commit enforce the repo must in clean state after make distclean:
https://github.com/apache/incubator-nuttx-apps/commit/989988fa7203ab5e5d26b140c8a43ddeb41d578e
But the current mainline doesn't fix all issue yet. I will provide a patch temporarily until we clean up the code base.
>
> CC frontends/conf/frontends_conf_kconfig_conf-conf.o
> frontends/conf/conf.c:78:10: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
> printf(_("aborted!\n\n")); ^~~~~~~~~~~~~~~~~ ./libs/parser/lkc.h:34:17: note: expanded from macro '_'
> #define _(text) gettext(text) ^~~~~~~~~~~~~ frontends/conf/conf.c:78:10: note: treat the string as an argument to avoid this printf(_("aborted!\n\n"));
> ^
> "%s",
> ./libs/parser/lkc.h:34:17: note: expanded from macro '_' #define _(text) gettext(text) ^ frontends/conf/conf.c:79:10: warning: format string is not a string literal (potentially insecure) [-Wformat-security] printf(_("Console input/output is redirected. ")); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./libs/parser/lkc.h:34:17: note: expanded from macro '_'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] juniskane commented on issue #198: webclient: use getaddrinfo to get IPv4 addresses on dual stack systems
Posted by GitBox <gi...@apache.org>.
juniskane commented on issue #198:
URL: https://github.com/apache/incubator-nuttx-apps/pull/198#issuecomment-618417102
Done rebase + force push. Feel free to take this or similar actions for my branches in the future if I'm absent. I consider my PR branches ephemeral. But now the CI is failing due to Internal Error 500 *sigh*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org