You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/26 11:57:21 UTC
[GitHub] [iotdb] CRZbulabula opened a new pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation
CRZbulabula opened a new pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233#issuecomment-951905073
[](https://coveralls.io/builds/43777089)
Coverage increased (+0.1%) to 67.028% when pulling **c4e584e64c3d71ebde87a7445030e5d2bed5da96 on CRZbulabula:Distinguish_between_zero_and_null_values_in_sum_aggregation** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233#issuecomment-951905073
[](https://coveralls.io/builds/43837461)
Coverage increased (+0.07%) to 66.992% when pulling **db2438b1db692a9e634b0d579e9b4780a3497bbc on CRZbulabula:Distinguish_between_zero_and_null_values_in_sum_aggregation** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233#issuecomment-951905073
[](https://coveralls.io/builds/43781617)
Coverage increased (+0.1%) to 67.042% when pulling **7a84da91d7d85babfecdc92182331ce3bafa8650 on CRZbulabula:Distinguish_between_zero_and_null_values_in_sum_aggregation** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233#issuecomment-951905073
[](https://coveralls.io/builds/43777083)
Coverage increased (+0.1%) to 67.059% when pulling **c4e584e64c3d71ebde87a7445030e5d2bed5da96 on CRZbulabula:Distinguish_between_zero_and_null_values_in_sum_aggregation** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on a change in pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation
Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on a change in pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233#discussion_r738879693
##########
File path: server/src/main/java/org/apache/iotdb/db/query/aggregation/impl/SumAggrResult.java
##########
@@ -37,28 +37,40 @@
public class SumAggrResult extends AggregateResult {
private TSDataType seriesDataType;
+ private double sum;
+ private boolean notNull;
Review comment:
I think these two fields are unnecessary. You can use `doubleValue` and `hasCandidateResult` in `AggregateResult `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233#issuecomment-951905073
[](https://coveralls.io/builds/43782392)
Coverage increased (+0.1%) to 67.038% when pulling **7a84da91d7d85babfecdc92182331ce3bafa8650 on CRZbulabula:Distinguish_between_zero_and_null_values_in_sum_aggregation** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233#issuecomment-951905073
[](https://coveralls.io/builds/43863198)
Coverage decreased (-0.02%) to 66.898% when pulling **80f83557e107f3d4b5395d19b982ab1439e6f0c3 on CRZbulabula:Distinguish_between_zero_and_null_values_in_sum_aggregation** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233#issuecomment-951905073
[](https://coveralls.io/builds/43836814)
Coverage increased (+0.07%) to 66.995% when pulling **db2438b1db692a9e634b0d579e9b4780a3497bbc on CRZbulabula:Distinguish_between_zero_and_null_values_in_sum_aggregation** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233#issuecomment-951905073
[](https://coveralls.io/builds/43863135)
Coverage increased (+0.1%) to 67.019% when pulling **80f83557e107f3d4b5395d19b982ab1439e6f0c3 on CRZbulabula:Distinguish_between_zero_and_null_values_in_sum_aggregation** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] CRZbulabula commented on a change in pull request #4233: [IOTDB-1884] Distinguish between zero and null values in sum aggregation
Posted by GitBox <gi...@apache.org>.
CRZbulabula commented on a change in pull request #4233:
URL: https://github.com/apache/iotdb/pull/4233#discussion_r738889522
##########
File path: server/src/main/java/org/apache/iotdb/db/query/aggregation/impl/SumAggrResult.java
##########
@@ -37,28 +37,40 @@
public class SumAggrResult extends AggregateResult {
private TSDataType seriesDataType;
+ private double sum;
+ private boolean notNull;
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org