You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/01/09 02:49:24 UTC
[GitHub] [libcloud] c-w opened a new pull request #1404: Fix CI on Windows
c-w opened a new pull request #1404: Fix CI on Windows
URL: https://github.com/apache/libcloud/pull/1404
## Fix CI on Windows
### Description
The Travis CI build on Windows is currently failing (e.g. see [5073.4](https://travis-ci.org/apache/libcloud/jobs/634519562) or [5074.4](https://travis-ci.org/apache/libcloud/jobs/634521136)) due to an error installing Python via Chocolatey.
This pull request fixes the CI by updating the build to use the latest Python published to Chocolatey (3.8). This also required updating the cryptography dependency to the latest version (2.8) since the previously pinned version (2.6.1) doesn't include a wheel for Python 3.8 on Windows.
### Status
- done, ready for review
### Checklist
- [ ] Code linting (n/a, infrastructure-only change)
- [ ] Documentation (n/a, infrastructure-only change)
- [x] Tests ([CI passed](https://travis-ci.org/CatalystCode/libcloud/builds/634540141))
- [x] ICLA [committer](http://people.apache.org/phonebook.html?uid=clewolff)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] c-w commented on issue #1404: Fix CI on Windows
Posted by GitBox <gi...@apache.org>.
c-w commented on issue #1404: Fix CI on Windows
URL: https://github.com/apache/libcloud/pull/1404#issuecomment-572584987
Turns out this was a temporary (but persistent over multiple hours) bug with Chocolatey yesterday which failed installs when `--version` was specified. While the issue now seems resolved (e.g. see successful build [108.4](https://travis-ci.org/CatalystCode/libcloud/jobs/634766906) which pins Python 3.8.1), I'd say that it's still worth merging this PR to get the Windows CI updated to the latest Python version. I'll rename the PR before merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] c-w edited a comment on issue #1404: Update Python used
in Windows CI to 3.8
Posted by GitBox <gi...@apache.org>.
c-w edited a comment on issue #1404: Update Python used in Windows CI to 3.8
URL: https://github.com/apache/libcloud/pull/1404#issuecomment-572584987
Turns out this was a temporary (but persistent over multiple hours) bug with Chocolatey yesterday which failed installs when `--version` was specified. While the issue now seems resolved (e.g. see successful build [which pins Python 3.8.1](https://travis-ci.org/CatalystCode/libcloud/jobs/634766906) and one [which pins Python 3.7.5](https://travis-ci.org/apache/libcloud/jobs/634519562)), I'd say that it's still worth merging this PR to get the Windows CI updated to the latest Python version. I'll rename the PR before merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io edited a comment on issue #1404: Update
Python used in Windows CI to 3.8
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1404: Update Python used in Windows CI to 3.8
URL: https://github.com/apache/libcloud/pull/1404#issuecomment-572364283
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1404?src=pr&el=h1) Report
> Merging [#1404](https://codecov.io/gh/apache/libcloud/pull/1404?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/a97ab7323feb24dffb80563dea8b5846b74dbfad?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/libcloud/pull/1404?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1404 +/- ##
=======================================
Coverage 86.45% 86.45%
=======================================
Files 366 366
Lines 76751 76751
Branches 7527 7527
=======================================
Hits 66352 66352
Misses 7532 7532
Partials 2867 2867
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1404?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1404?src=pr&el=footer). Last update [a97ab73...634f60c](https://codecov.io/gh/apache/libcloud/pull/1404?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] c-w merged pull request #1404: Update Python used in
Windows CI to 3.8
Posted by GitBox <gi...@apache.org>.
c-w merged pull request #1404: Update Python used in Windows CI to 3.8
URL: https://github.com/apache/libcloud/pull/1404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io commented on issue #1404: Fix CI on Windows
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1404: Fix CI on Windows
URL: https://github.com/apache/libcloud/pull/1404#issuecomment-572364283
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1404?src=pr&el=h1) Report
> Merging [#1404](https://codecov.io/gh/apache/libcloud/pull/1404?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/813b44e09245035fa4a86388fda4357509a30498?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/libcloud/pull/1404?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1404 +/- ##
=======================================
Coverage 86.37% 86.37%
=======================================
Files 366 366
Lines 76865 76865
Branches 7546 7546
=======================================
Hits 66390 66390
Misses 7607 7607
Partials 2868 2868
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1404?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1404?src=pr&el=footer). Last update [813b44e...7c95a95](https://codecov.io/gh/apache/libcloud/pull/1404?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami commented on issue #1404: Fix CI on Windows
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1404: Fix CI on Windows
URL: https://github.com/apache/libcloud/pull/1404#issuecomment-572405955
Thanks for the fix.
If I understand correctly, chocolatey on Travis only supports a single (latest) version of Python 3?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services