You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/29 11:46:45 UTC
[GitHub] [druid] abhishekagarwal87 opened a new pull request #10449: Fix the offset in get of GCP object
abhishekagarwal87 opened a new pull request #10449:
URL: https://github.com/apache/druid/pull/10449
Fixes #7076.
### Description
Upgraded the GCP HTTP client libraries to bring in the fix for https://github.com/googleapis/google-http-java-client/pull/447
Also added tests using `MockHttpTransport` to verify that skipping is happening as expected. There was another bug in the
`org.apache.druid.storage.google.GoogleStorage#get(java.lang.String, java.lang.String, long)`. offset was being set on the media downloader which is not actually used when `executeMediaAsInputStream` is invoked. So setting the offset was a no-op.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
<hr>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #10449: Fix the offset setting in GoogleStorage#get
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on pull request #10449:
URL: https://github.com/apache/druid/pull/10449#issuecomment-700798766
will fix the license checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh merged pull request #10449: Fix the offset setting in GoogleStorage#get
Posted by GitBox <gi...@apache.org>.
ccaominh merged pull request #10449:
URL: https://github.com/apache/druid/pull/10449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] glasser commented on pull request #10449: Fix the offset setting in GoogleStorage#get
Posted by GitBox <gi...@apache.org>.
glasser commented on pull request #10449:
URL: https://github.com/apache/druid/pull/10449#issuecomment-702278445
Thanks! This has been annoying me for 1.5 years but I never quite managed to fix it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh commented on a change in pull request #10449: Fix the offset setting in GoogleStorage#get
Posted by GitBox <gi...@apache.org>.
ccaominh commented on a change in pull request #10449:
URL: https://github.com/apache/druid/pull/10449#discussion_r496904149
##########
File path: extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleTaskLogsTest.java
##########
@@ -134,19 +134,21 @@ public void testStreamTaskLogWithoutOffset() throws Exception
public void testStreamTaskLogWithPositiveOffset() throws Exception
{
final String testLog = "hello this is a log";
+ final String expectedLog = testLog.substring(5);
Review comment:
Since it appears in a couple places for this method, may be useful to have a named constant in this method for the value 5, similar to what was done in `testStreamTaskLogWithNegative()`.
##########
File path: pom.xml
##########
@@ -118,8 +118,9 @@
<!-- When upgrading ZK, edit docs and integration tests as well (integration-tests/docker-base/setup.sh) -->
<zookeeper.version>3.4.14</zookeeper.version>
<checkerframework.version>2.5.7</checkerframework.version>
- <com.google.apis.client.version>1.25.0</com.google.apis.client.version>
- <com.google.apis.compute.version>v1-rev214-1.25.0</com.google.apis.compute.version>
+ <com.google.apis.client.version>1.26.0</com.google.apis.client.version>
+ <com.google.apis.compute.version>v1-rev20190607-1.26.0</com.google.apis.compute.version>
+ <com.google.apis.storage.version>v1-rev20190523-1.26.0</com.google.apis.storage.version>
Review comment:
Similar to what was previously done in `extensions-core/google-extensions/pom.xml`, does it make sense to have the `1.26.0` suffix value provided by the `com.google.apis.client.version` property?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org