You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by David Kantor <dk...@us.ibm.com> on 2017/02/02 16:30:32 UTC
Re: Review Request 54858: Atlas-1178: Use .gitignore so git does not
see binary files as changed
> On Jan. 30, 2017, 9:04 p.m., David Kantor wrote:
> > .gitignore, line 1
> > <https://reviews.apache.org/r/54858/diff/3/?file=1604866#file1604866line1>
> >
> > Please set the bugs field to ATLAS-1378 and fix the summary to mention ATLAS-1378 rather than 1178.
Please set the bugs field to ATLAS-1378 and fix the summary to mention ATLAS-1378 rather than 1178. Also, please close this request as Submitted. To do that, go to My Dashboard, click the check box next to this request, and then click Close Submitted. Thanks...
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54858/#review163570
-----------------------------------------------------------
On Jan. 13, 2017, 4:35 p.m., David Radley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54858/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 4:35 p.m.)
>
>
> Review request for atlas and David Kantor.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added .gitignore files so git does not see binary files as changed. Atlas type system project has a strange .gitignore that I have not touched. I notice it contains ignores for Eclipse files, but the way we run it the eclipse files are not picked up by git.
>
>
> Diffs
> -----
>
> .gitignore cf2ef7445407f846329b0849d23dcb0aecc4d242
>
> Diff: https://reviews.apache.org/r/54858/diff/
>
>
> Testing
> -------
>
> git status shows no untracked changes after a compile.
>
>
> Thanks,
>
> David Radley
>
>
Re: Review Request 54858: Atlas-1178: Use .gitignore so git does not see
binary files as changed
Posted by David Radley <da...@uk.ibm.com>.
Hi David,
I have made these changes,
all the best, David.
From: David Kantor <dk...@us.ibm.com>
To: David Kantor <dk...@us.ibm.com>
Cc: David Radley/UK/IBM@IBMGB, Apoorv Naik <na...@gmail.com>,
atlas <de...@atlas.incubator.apache.org>
Date: 02/02/2017 16:31
Subject: Re: Review Request 54858: Atlas-1178: Use .gitignore so
git does not see binary files as changed
Sent by: David Kantor <no...@reviews.apache.org>
> On Jan. 30, 2017, 9:04 p.m., David Kantor wrote:
> > .gitignore, line 1
> > <
https://reviews.apache.org/r/54858/diff/3/?file=1604866#file1604866line1>
> >
> > Please set the bugs field to ATLAS-1378 and fix the summary to
mention ATLAS-1378 rather than 1178.
Please set the bugs field to ATLAS-1378 and fix the summary to mention
ATLAS-1378 rather than 1178. Also, please close this request as
Submitted. To do that, go to My Dashboard, click the check box next to
this request, and then click Close Submitted. Thanks...
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54858/#review163570
-----------------------------------------------------------
On Jan. 13, 2017, 4:35 p.m., David Radley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54858/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 4:35 p.m.)
>
>
> Review request for atlas and David Kantor.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added .gitignore files so git does not see binary files as changed.
Atlas type system project has a strange .gitignore that I have not
touched. I notice it contains ignores for Eclipse files, but the way we
run it the eclipse files are not picked up by git.
>
>
> Diffs
> -----
>
> .gitignore cf2ef7445407f846329b0849d23dcb0aecc4d242
>
> Diff: https://reviews.apache.org/r/54858/diff/
>
>
> Testing
> -------
>
> git status shows no untracked changes after a compile.
>
>
> Thanks,
>
> David Radley
>
>
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU